LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: "jh80.chung@samsung.com" <jh80.chung@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"linux-snps-arc@lists.infradead.org"
	<linux-snps-arc@lists.infradead.org>,
	"kgene@kernel.org" <kgene@kernel.org>,
	"shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>
Subject: Re: [RFC 0/2] dw_mmc: add multislot support
Date: Thu, 26 Apr 2018 08:28:04 +0200	[thread overview]
Message-ID: <CAPDyKFr4WXgFEDLGztRoSrAFMrHC7ASJxaxCTKMeGN8i-Ns86w@mail.gmail.com> (raw)
In-Reply-To: <1524664417.18209.16.camel@synopsys.com>

[...]

> A bit remark for better understanding:
>
> All card settings change are serialized too. These settings are applied
> after slot switch before execution of new request for this slot.
>
> So situations like calling any host_0 ops while another host (host_1) is active
> are handled by current code.
>
> This is example of simultaneous ops calls for both slots:
>
> host (slot) 0    | host (slot) 1
> -----------------------------------
> h0->set_ios()    |    h1->set_ios()
> h0->request()    |    h1->request()
> h0->set_ios()    |    h1->set_ios()
> h0->request()    |    h1->request()
> h0->request()    |
> h0->request()    |
> h0->request()    |
>
> How it will be serialized in the mmc driver:
>
> h0->set_ios()   // h0 settings save
> h1->set_ios()   // h1 settings save
> h0->request()   // apply settings for h0 and do request

This doesn't work as it would mean violation of the specs in some
scenarios. Particular during the card initialization and card power
off.

> ------ slot switch to h1 ------
> h1->request()   // apply settings for h1 and do request

Ditto. Etc...

> h0->set_ios()   // h0 settings save
> h1->set_ios()   // h1 settings save
> ------ slot switch to h0 ------
> h0->request()   // apply settings for h0 and do request
> ------ slot switch to h1 ------
> h1->request()   // apply settings for h1 and do request
> ------ slot switch to h0 ------
> h0->request()   // do request (no new settings to apply)
> h0->request()   // do request (no new settings to apply)
> h0->request()   // do request (no new settings to apply)
>

Kind regards
Uffe

  reply	other threads:[~2018-04-26  6:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180417121325epcas2p319c672feee4203d8b90131da461f4bd6@epcas2p3.samsung.com>
2018-04-17 12:11 ` Eugeniy Paltsev
2018-04-17 12:11   ` [RFC 1/2] dw_mmc: revert removal " Eugeniy Paltsev
2018-04-17 12:11   ` [RFC 2/2] dw_mmc: add " Eugeniy Paltsev
2018-04-20  7:35   ` [RFC 0/2] " Ulf Hansson
2018-04-20  7:42     ` Alexey Brodkin
2018-04-20  8:56       ` Ulf Hansson
2018-04-20 15:53     ` Eugeniy Paltsev
2018-04-23  6:47       ` Ulf Hansson
2018-04-25 13:53         ` Eugeniy Paltsev
2018-04-26  6:28           ` Ulf Hansson [this message]
2018-04-26 10:30   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFr4WXgFEDLGztRoSrAFMrHC7ASJxaxCTKMeGN8i-Ns86w@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=jh80.chung@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=shawn.lin@rock-chips.com \
    --subject='Re: [RFC 0/2] dw_mmc: add multislot support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).