LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: linux-next: build warning after merge of the mmc tree
Date: Thu, 2 Nov 2017 16:03:26 +0100	[thread overview]
Message-ID: <CAPDyKFruW7-D5yWb5TH4DWtLTFdwcbFdMGfwSy7089t-7VJTdg@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=VD2mgZQLS7q=iKzZOZ1_-FN1XR=gN8+60w_=zZJObVfA@mail.gmail.com>

On 2 November 2017 at 02:47, Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Wed, Nov 1, 2017 at 6:36 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi Ulf,
>>
>> After merging the mmc tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> In file included from include/linux/irqflags.h:14:0,
>>                  from arch/arm/include/asm/bitops.h:27,
>>                  from include/linux/bitops.h:37,
>>                  from include/linux/kernel.h:10,
>>                  from include/asm-generic/bug.h:15,
>>                  from arch/arm/include/asm/bug.h:59,
>>                  from include/linux/bug.h:4,
>>                  from include/linux/thread_info.h:11,
>>                  from include/asm-generic/current.h:4,
>>                  from ./arch/arm/include/generated/asm/current.h:1,
>>                  from include/linux/sched.h:11,
>>                  from include/linux/blkdev.h:4,
>>                  from drivers/mmc/host/dw_mmc.c:14:
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_drto':
>> include/linux/typecheck.h:11:18: warning: comparison of distinct pointer types lacks a cast
>>   (void)(&__dummy == &__dummy2); \
>>                   ^
>> include/linux/spinlock.h:221:3: note: in expansion of macro 'typecheck'
>>    typecheck(unsigned long, flags); \
>>    ^
>> include/linux/spinlock.h:346:2: note: in expansion of macro 'raw_spin_lock_irqsave'
>>   raw_spin_lock_irqsave(spinlock_check(lock), flags); \
>>   ^
>> drivers/mmc/host/dw_mmc.c:1953:2: note: in expansion of macro 'spin_lock_irqsave'
>>   spin_lock_irqsave(&host->irq_lock, irqflags);
>>   ^
>>
>> Introduced by commit
>>
>>   80a2a5a7745b ("mmc: dw_mmc: Cleanup the DTO timer like the CTO one")
>
> Yes, the 0-day bot already complained about this.  The short answer is
> that Ulf kindly volunteered to manually fix up my patch series where I
> had introduced a variable in the wrong patch.  ...but in doing so he
> introduced a small bug.
>
> It should be very easy to fix.  Just need to change irqflags from
> "unsigned int" to "unsigned long".

Yes, problem fixed!

Kind regards
Uffe

  reply	other threads:[~2017-11-02 15:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02  1:36 Stephen Rothwell
2017-11-02  1:47 ` Doug Anderson
2017-11-02 15:03   ` Ulf Hansson [this message]
2019-03-19  1:15 Stephen Rothwell
2019-10-22  0:47 Stephen Rothwell
2019-10-22  7:31 ` Ulf Hansson
2020-02-19 23:31 Stephen Rothwell
2020-02-20  1:38 ` Baolin Wang
2021-08-25  3:20 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFruW7-D5yWb5TH4DWtLTFdwcbFdMGfwSy7089t-7VJTdg@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=shawn.lin@rock-chips.com \
    --subject='Re: linux-next: build warning after merge of the mmc tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).