From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D39BC04AAB for ; Tue, 7 May 2019 15:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DB712087F for ; Tue, 7 May 2019 15:37:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="1RDaQiep" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfEGPhN (ORCPT ); Tue, 7 May 2019 11:37:13 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:41669 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbfEGPhN (ORCPT ); Tue, 7 May 2019 11:37:13 -0400 Received: by mail-ot1-f65.google.com with SMTP id g8so15321550otl.8 for ; Tue, 07 May 2019 08:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6dOaY+uD9DJjErKzQ4lbx3sa2d0JDi7CHezoB5wTbvY=; b=1RDaQiep4r+5NZ7RO5zftr0FnsMUZwAyLWkMBkR9iTDOBSIJayhPK4u9DWG7+9yxpt 9FJnbG3lrhIL0LedEM5ytUIEEGfVVBYdsCV16Q3ZevH87Y7p3IJljktvzFGtbrtOW9jV qgMeHUIAfkrXfVgCh+wJIUgLwx8HPs0Hso14g3nE34tG3uE5Kaf93v1albOqeZ8FtzEo MRnNU+jjU7Bd7Hg2HKOClTmC45crVs8w8TurxKr/6z1WENdYw/y//CLDQEQmIA9Rf7i+ OKLRLxxsnQvga0Mn1E5gFobavHOZ9OlvYblRdklzqgaUM3FSIzUzMZWnI38rOf5/Ueyc SI6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6dOaY+uD9DJjErKzQ4lbx3sa2d0JDi7CHezoB5wTbvY=; b=NurwmmJXTRs42HMHxK8iAY7ttPdX2enmVkSe5mejYBD0S5pqDNpf5A7POzdi7YnOEO PoDq/YldPDrhwYFtWgsvHEZODfdL2o5pIkKgxSbpjdDKfATqYOeeAG9dcaC6w9tu1j2K ApesLkvqzvOzXZelwkowLNizD8p3DomXr786+YPLY2XyBzKD2lnai696vjLqk8H3Fw4i IGlEV6jSB92j0leUgnPWYtE7qhe4km41qUSqnNw3O3gmdUpuu5u1ancncdANByiRFygj mWJj13ILv+pb2Npieu9PIz2LAUlpIeWlGD7dLi3qqWTubUGfZq5vSNsgd8N0mGWztu+j og7w== X-Gm-Message-State: APjAAAWzAwtaxQ9/bU7+fkU4d+PBLdR+kIgyLQollGpJmPlf/cktSfzR BPxYIOf3JRXKoQq0XYdwzgMXteG7HexTDZZCYt7MQg== X-Google-Smtp-Source: APXvYqxbxERKNtTaVpMxD9jAh6w8zsl3plIje9NPoM99XF0whcoJ/rqAndFua0o+8QlJA2fPNaeXZRcDVPm+ejCVDvk= X-Received: by 2002:a9d:222c:: with SMTP id o41mr22019501ota.353.1557243432435; Tue, 07 May 2019 08:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-7-pagupta@redhat.com> In-Reply-To: <20190426050039.17460-7-pagupta@redhat.com> From: Dan Williams Date: Tue, 7 May 2019 08:37:01 -0700 Message-ID: Subject: Re: [PATCH v7 6/6] xfs: disable map_sync for async flush To: Pankaj Gupta Cc: linux-nvdimm , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, KVM list , linux-fsdevel , Linux ACPI , Qemu Developers , linux-ext4 , linux-xfs , Ross Zwisler , Vishal L Verma , Dave Jiang , "Michael S. Tsirkin" , Jason Wang , Matthew Wilcox , "Rafael J. Wysocki" , Christoph Hellwig , Len Brown , Jan Kara , "Theodore Ts'o" , Andreas Dilger , "Darrick J. Wong" , lcapitulino@redhat.com, Kevin Wolf , Igor Mammedov , jmoyer , Nitesh Narayan Lal , Rik van Riel , Stefan Hajnoczi , Andrea Arcangeli , David Hildenbrand , david , cohuck@redhat.com, Xiao Guangrong , Paolo Bonzini , kilobyte@angband.pl, yuval shaia Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 25, 2019 at 10:03 PM Pankaj Gupta wrote: > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > with asynchronous dax_device. Virtio pmem provides > asynchronous host page cache flush mechanism. We don't > support 'MAP_SYNC' with virtio pmem and xfs. > > Signed-off-by: Pankaj Gupta > --- > fs/xfs/xfs_file.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Darrick, does this look ok to take through the nvdimm tree? > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index a7ceae90110e..f17652cca5ff 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1203,11 +1203,14 @@ xfs_file_mmap( > struct file *filp, > struct vm_area_struct *vma) > { > + struct dax_device *dax_dev; > + > + dax_dev = xfs_find_daxdev_for_inode(file_inode(filp)); > /* > - * We don't support synchronous mappings for non-DAX files. At least > - * until someone comes with a sensible use case. > + * We don't support synchronous mappings for non-DAX files and > + * for DAX files if underneath dax_device is not synchronous. > */ > - if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC)) > + if (!daxdev_mapping_supported(vma, dax_dev)) > return -EOPNOTSUPP; > > file_accessed(filp); > -- > 2.20.1 >