LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type
@ 2018-04-24 13:15 Luc Van Oostenryck
  2018-04-24 17:28 ` Robin Holt
  0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Cliff Whickman, Robin Holt, Arnd Bergmann,
	Greg Kroah-Hartman

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Acked-by: Robin Holt <robinmholt@gmail.com>
---
 drivers/misc/sgi-xp/xpnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
index 0c26eaf5f..216d5c756 100644
--- a/drivers/misc/sgi-xp/xpnet.c
+++ b/drivers/misc/sgi-xp/xpnet.c
@@ -407,7 +407,7 @@ xpnet_send(struct sk_buff *skb, struct xpnet_pending_msg *queued_msg,
  * destination partid.  If the destination partid octets are 0xffff,
  * this packet is to be broadcast to all connected partitions.
  */
-static int
+static netdev_tx_t
 xpnet_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct xpnet_pending_msg *queued_msg;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type
  2018-04-24 13:15 [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type Luc Van Oostenryck
@ 2018-04-24 17:28 ` Robin Holt
  0 siblings, 0 replies; 2+ messages in thread
From: Robin Holt @ 2018-04-24 17:28 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: LKML, Cliff Whickman, Arnd Bergmann, Greg Kroah-Hartman

On Tue, Apr 24, 2018 at 8:15 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Acked-by: Robin Holt <robinmholt@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-24 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:15 [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type Luc Van Oostenryck
2018-04-24 17:28 ` Robin Holt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).