LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel G <dagmcr@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: open list <linux-kernel@vger.kernel.org>,
	Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH] spi: TI power management: add missing of table registration
Date: Sat, 11 May 2019 10:28:21 +0200	[thread overview]
Message-ID: <CAPsT6hmVQWNtt2cLWkVQ8kHa_Q_7KVp4D-mMnjBsajdYdn8EeA@mail.gmail.com> (raw)
In-Reply-To: <20190508102701.GI3995@dell>

On Wed, May 8, 2019 at 12:27 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> The subject line is not correct.  This is an MFD driver.
>
> When submitting you should follow the convention for the subsystem you
> are patching against.  The following command is helpful:
>
>   `git log --oneline -- <SUBSYSTEM>`
>
> I will fix it for you this time (and for the other patch I see).
>
Sorry for that and thanks for rewriting the subject.

> On Mon, 22 Apr 2019, Daniel Gomez wrote:
>
> > MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> > OF mathing mechanism and register it.
> >
> > Before this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          spi:tps65912
> >
> > After this patch:
> > modinfo drivers/mfd/tps65912-spi.ko | grep alias
> > alias:          of:N*T*Cti,tps65912C*
> > alias:          of:N*T*Cti,tps65912
> > alias:          spi:tps65912
> >
> > Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> > Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> > ---
> >  drivers/mfd/tps65912-spi.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied, thanks.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2019-05-11  8:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 19:09 Daniel Gomez
2019-05-08 10:27 ` Lee Jones
2019-05-11  8:28   ` Daniel G [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPsT6hmVQWNtt2cLWkVQ8kHa_Q_7KVp4D-mMnjBsajdYdn8EeA@mail.gmail.com \
    --to=dagmcr@gmail.com \
    --cc=javier@dowhile0.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] spi: TI power management: add missing of table registration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).