LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Liam Beguin" <liambeguin@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>, <lars@metafoo.de>,
	<Michael.Hennerich@analog.com>,
	<charles-antoine.couret@essensium.com>, <Nuno.Sa@analog.com>,
	<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref
Date: Tue, 10 Aug 2021 15:46:16 -0400	[thread overview]
Message-ID: <CDG3ATRV00VV.57ZPL3OPU5N4@shaak> (raw)
In-Reply-To: <CAHp75Vc3o-RrHD_wt_CfJY3P8hoRhJkdiRRySFS_O_7VdtJTQA@mail.gmail.com>

On Tue Aug 10, 2021 at 8:15 AM EDT, Andy Shevchenko wrote:
> On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@gmail.com> wrote:
> > On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > > On Sat, 7 Aug 2021 21:56:57 -0400
> >         ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> >         if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
> >                 continue;
>
> >         } else if (ret < 0) {
>

Hi Andy,

> Side note, redundant 'else'

Are you asking to add an 'else' statement?

because, unless I'm mistaken, in this case ret can have other negative values
that we want to catch with this 'else if'.

Thanks for your time,
Liam

>
> >                 dev_err(dev, "invalid voltage reference in %pfw\n", child);
> >                 fwnode_handle_put(child);
> >                 return ret;
> >         }
>
>
> --
> With Best Regards,
> Andy Shevchenko


  reply	other threads:[~2021-08-10 19:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  1:56 [PATCH v5 0/5] AD7949 Fixes Liam Beguin
2021-08-08  1:56 ` [PATCH v5 1/5] iio: adc: ad7949: define and use bitfield names Liam Beguin
2021-08-08 16:51   ` Joe Perches
2021-08-08 22:46     ` Liam Beguin
2021-08-09 20:03       ` Joe Perches
2021-08-08  1:56 ` [PATCH v5 2/5] iio: adc: ad7949: fix spi messages on non 14-bit controllers Liam Beguin
2021-08-08  1:56 ` [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref Liam Beguin
2021-08-08 16:36   ` Jonathan Cameron
2021-08-08 22:43     ` Liam Beguin
2021-08-09 19:42       ` Jonathan Cameron
2021-08-13 20:51         ` Liam Beguin
2021-08-16  8:07           ` Andy Shevchenko
2021-08-10 12:15       ` Andy Shevchenko
2021-08-10 19:46         ` Liam Beguin [this message]
2021-08-10 19:55           ` Andy Shevchenko
2021-08-10 20:51             ` Liam Beguin
2021-08-08  1:56 ` [PATCH v5 4/5] dt-bindings: iio: adc: ad7949: add per channel reference Liam Beguin
2021-08-08  1:56 ` [PATCH v5 5/5] iio: adc: ad7949: use devm managed functions Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CDG3ATRV00VV.57ZPL3OPU5N4@shaak \
    --to=liambeguin@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=Nuno.Sa@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=charles-antoine.couret@essensium.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).