LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Manish Rangankar <mrangankar@marvell.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	Nilesh Javali <njavali@marvell.com>,
	GR-QLogic-Storage-Upstream
	<GR-QLogic-Storage-Upstream@marvell.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"open list:QLOGIC QL41xxx ISCSI DRIVER"
	<linux-scsi@vger.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
Date: Sat, 27 Nov 2021 09:14:51 +0000	[thread overview]
Message-ID: <CO6PR18MB44197657240086A7B674F00CD8649@CO6PR18MB4419.namprd18.prod.outlook.com> (raw)
In-Reply-To: <be1624fe-f1e5-f008-32e8-af00a36e284c@gmail.com>

> >>   	list = (u64 *)qedi->bdq_pbl_list;
> >> -	page = qedi->bdq_pbl_list_dma;
> >>   	for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
> >>   		*list = qedi->bdq_pbl_dma;
> >>   		list++;
> >> -		page += QEDI_PAGE_SIZE;
> >>   	}
> >>
> >>   	return 0;
> >> --
> >> 2.25.1
> >
> > Thanks,
> > Acked-by: Manish Rangankar <mrangankar@marvell.com>
> 
> Thanks for taking a look, does not that make the loop iterating the list even
> more useless now, though? Should not page have been used for something in
> that function?
> --

We need list to build structure of bdq list in firmware understandable format.



  reply	other threads:[~2021-11-27  9:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  5:15 [PATCH 0/2] scsi: qedi: Couple of warning fixes Florian Fainelli
2021-11-26  5:15 ` [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable Florian Fainelli
2021-11-26  8:52   ` [EXT] " Manish Rangankar
2021-11-27  5:31     ` Florian Fainelli
2021-11-27  9:14       ` Manish Rangankar [this message]
2021-11-26  5:15 ` [PATCH 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting Florian Fainelli
2021-11-26  8:43   ` [EXT] " Manish Rangankar
2021-11-27  5:31     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB44197657240086A7B674F00CD8649@CO6PR18MB4419.namprd18.prod.outlook.com \
    --to=mrangankar@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=f.fainelli@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    --subject='RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused '\''page'\'' variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).