[Patch] bug in gdth.c crashing machine

[Patch] bug in gdth.c crashing machine

[Joerg Dorchain]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<EF6AF37986D67948AD48624A3E5D93AFE72291@mtce2k01.adaptec.com>,
I'd be pleased if you could integrate the derived patch into a bugfix
release of the driver asap.

This bug kept me busy for three days, endangering  backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

Signed-off-by: Joerg Dorchain <joerg@dorchain.net>

--- gdth.c.orig	2007-02-23 12:48:56.000000000 +0100
+++ gdth.c	2007-02-23 12:51:44.000000000 +0100
@@ -3092,6 +3092,7 @@
             cmdp->u.raw64.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+            cmdp->u.raw64.sg_ranz    = 0;
         } else {
             cmdp->u.raw.reserved   = 0;
             cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
             cmdp->u.raw.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+            cmdp->u.raw.sg_ranz    = 0;
         }
 
         if (scp->use_sg) {

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

RE: [Patch] bug in gdth.c crashing machine

[Leubner, Achim]

Hi Joerg,

You are right, this patch should be added to a bugfix release as soon as
possible. 

Thanks,
Achim

=======================
Achim Leubner
Software Engineer / RAID drivers
ICP vortex GmbH / Adaptec Inc.
Phone: +49-351-8718291
 

-----Original Message-----
From: Joerg Dorchain [mailto:joerg@dorchain.net] 
Sent: Freitag, 23. Februar 2007 14:30
To: Leubner, Achim
Cc: linux-kernel@vger.kernel.org
Subject: [Patch] bug in gdth.c crashing machine

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<EF6AF37986D67948AD48624A3E5D93AFE72291@mtce2k01.adaptec.com>,
I'd be pleased if you could integrate the derived patch into a bugfix
release of the driver asap.

This bug kept me busy for three days, endangering  backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

Signed-off-by: Joerg Dorchain <joerg@dorchain.net>

--- gdth.c.orig	2007-02-23 12:48:56.000000000 +0100
+++ gdth.c	2007-02-23 12:51:44.000000000 +0100
@@ -3092,6 +3092,7 @@
             cmdp->u.raw64.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+            cmdp->u.raw64.sg_ranz    = 0;
         } else {
             cmdp->u.raw.reserved   = 0;
             cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
             cmdp->u.raw.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+            cmdp->u.raw.sg_ranz    = 0;
         }
 
         if (scp->use_sg) {