LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Chatre, Reinette" <reinette.chatre@intel.com>
To: "Joonwoo Park" <joonwpark81@gmail.com>,
	"Zhu, Yi" <yi.zhu@intel.com>, <netdev@vger.kernel.org>
Cc: <linux-wireless@vger.kernel.org>,
	"lkml" <linux-kernel@vger.kernel.org>,
	<ipw3945-devel@lists.sourceforge.net>
Subject: RE: [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand tasklet for down iwlwifi
Date: Thu, 10 Jan 2008 11:10:35 -0800	[thread overview]
Message-ID: <D936D925018D154694D8A362EEB08920035CCD70@orsmsx416.amr.corp.intel.com> (raw)
In-Reply-To: <11998765481610-git-send-email-joonwpark81@gmail.com>

On , Joonwoo Park  wrote:

> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -6262,6 +6262,10 @@ static void __iwl_down(struct iwl_priv *priv)
> 	/* tell the device to stop sending interrupts */
> 	iwl_disable_interrupts(priv);
> 
> +	/* synchronize irq and tasklet */
> +	synchronize_irq(priv->pci_dev->irq);
> +	tasklet_kill(&priv->irq_tasklet);
> +

Could synchronize_irq() be moved into iwl_disable_interrupts() ? I am
also wondering if we cannot call tasklet_kill() before
iwl_disable_interrupts() ... thus preventing it from being scheduled
when we are going down. 

Reinette

  reply	other threads:[~2008-01-10 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 11:02 [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi Joonwoo Park
2008-01-10 19:10 ` Chatre, Reinette [this message]
2008-01-11  1:24   ` [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand " Joonwoo Park
     [not found]     ` <D936D925018D154694D8A362EEB0892003602E2D@orsmsx416.amr.corp.intel.com>
     [not found]       ` <b25c3fa70801101838o7a71cc60h1c8b8a71624aeff9@mail.gmail.com>
2008-01-14  8:35         ` Joonwoo Park
2008-01-14  9:42           ` Joonwoo Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D936D925018D154694D8A362EEB08920035CCD70@orsmsx416.amr.corp.intel.com \
    --to=reinette.chatre@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=joonwpark81@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).