LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Liming Sun <lsun@mellanox.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension
Date: Tue, 8 May 2018 18:55:08 +0000	[thread overview]
Message-ID: <DB4PR05MB0768969F61B828B1B19A31DDA19A0@DB4PR05MB0768.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <a59e321a-2498-d9c1-4a22-296ffa13417a@rock-chips.com>

Thanks Shawn. Patch v7 has been sent out to address these comments.

> -----Original Message-----
> From: Shawn Lin [mailto:shawn.lin@rock-chips.com]
> Sent: Monday, April 23, 2018 9:11 PM
> To: Liming Sun <lsun@mellanox.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Jaehoon
> Chung <jh80.chung@samsung.com>; Catalin Marinas
> <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>;
> shawn.lin@rock-chips.com; linux-mmc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension
> 
> Hi Liming,
> 
> On 2018/4/23 23:32, Liming Sun wrote:
> > This commit adds extension to the dw_mmc driver for Mellanox BlueField
> > SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on
> > this SoC.
> >
> > Signed-off-by: Liming Sun <lsun@mellanox.com>
> > ---
> >   drivers/mmc/host/Kconfig            |  9 +++++
> >   drivers/mmc/host/Makefile           |  1 +
> >   drivers/mmc/host/dw_mmc-bluefield.c | 72
> +++++++++++++++++++++++++++++++++++++
> >   3 files changed, 82 insertions(+)
> >   create mode 100644 drivers/mmc/host/dw_mmc-bluefield.c
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 9589f9c..26ac6b5 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -717,6 +717,15 @@ config MMC_DW_K3
> >   	  Synopsys DesignWare Memory Card Interface driver. Select this
> option
> >   	  for platforms based on Hisilicon K3 SoC's.
> >
> > +config MMC_DW_BLUEFIELD
> > +	tristate "BlueField specific extensions for Synopsys DW Memory Card
> Interface"
> > +	depends on MMC_DW
> > +	select MMC_DW_PLTFM
> > +	help
> > +	  This selects support for Mellanox BlueField SoC specific extensions
> to
> > +	  the Synopsys DesignWare Memory Card Interface driver. Select this
> > +	  option for platforms based on Mellanox BlueField SoC's.
> > +
> 
> It'd better to keep the order, so you could place it before
> MMC_DW_EXYNOS.

Updated in v7 1/3.

> 
> >   config MMC_DW_PCI
> >   	tristate "Synopsys Designware MCI support on PCI bus"
> >   	depends on MMC_DW && PCI
> > diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
> > index 6aead24..267b3f1 100644
> > --- a/drivers/mmc/host/Makefile
> > +++ b/drivers/mmc/host/Makefile
> > @@ -55,6 +55,7 @@ obj-$(CONFIG_MMC_DW_K3)		+= dw_mmc-
> k3.o
> >   obj-$(CONFIG_MMC_DW_PCI)	+= dw_mmc-pci.o
> >   obj-$(CONFIG_MMC_DW_ROCKCHIP)	+= dw_mmc-rockchip.o
> >   obj-$(CONFIG_MMC_DW_ZX)		+= dw_mmc-zx.o
> > +obj-$(CONFIG_MMC_DW_BLUEFIELD)	+= dw_mmc-bluefield.o
> 
> Ditto.

Updated in v7 1/3.

> 
> >   obj-$(CONFIG_MMC_SH_MMCIF)	+= sh_mmcif.o
> >   obj-$(CONFIG_MMC_JZ4740)	+= jz4740_mmc.o
> >   obj-$(CONFIG_MMC_VUB300)	+= vub300.o
> > diff --git a/drivers/mmc/host/dw_mmc-bluefield.c
> b/drivers/mmc/host/dw_mmc-bluefield.c
> > new file mode 100644
> > index 0000000..12067b1
> > --- /dev/null
> > +++ b/drivers/mmc/host/dw_mmc-bluefield.c
> > @@ -0,0 +1,72 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2018 Mellanox Technologies.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/io.h>
> > +#include <linux/irq.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> > +#include <linux/mmc/host.h>
> > +#include <linux/mmc/mmc.h>
> > +#include <linux/of.h>
> > +
> 
> Ditto.

Updated in v7 1/3.

> 
> > +#include "dw_mmc.h"
> > +#include "dw_mmc-pltfm.h"
> > +
> > +static void dw_mci_bluefield_set_ios(struct dw_mci *host, struct
> mmc_ios *ios)
> > +{
> > +	u32 regs;
> > +
> > +	/* Set drive=4 (bit 29:23) and sample=2 (bit 22:16) in UHS_REG_EXT.
> */
> > +	regs = mci_readl(host, UHS_REG_EXT);
> > +	regs = (regs & ~0x3F100000 & ~0x7F0000) | (4 << 23) | (2 << 16);
> 
> GENMASK woule be more readable IMHO.

Updated in v7 1/3.

> 
> > +	mci_writel(host, UHS_REG_EXT, regs);
> > +}
> > +
> > +static const struct dw_mci_drv_data bluefield_drv_data = {
> > +	.set_ios		= dw_mci_bluefield_set_ios
> > +};
> > +
> > +static const struct of_device_id dw_mci_bluefield_match[] = {
> > +	{ .compatible = "mellanox,bluefield-dw-mshc",
> > +		.data = &bluefield_drv_data },
> 
> Keep the indent.

Updated in v7 1/3, assuming this comment is to let the ".data" aligned with the ".compatible".

> 
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(of, dw_mci_bluefield_match);
> > +
> > +static int dw_mci_bluefield_probe(struct platform_device *pdev)
> > +{
> > +	const struct dw_mci_drv_data *drv_data = NULL;
> > +	const struct of_device_id *match;
> > +
> > +	if (pdev->dev.of_node) {
> > +		match = of_match_node(dw_mci_bluefield_match,
> > +				      pdev->dev.of_node);
> > +		drv_data = match->data;
> > +	}
> > +
> > +	return dw_mci_pltfm_register(pdev, drv_data);
> > +}
> > +
> > +static struct platform_driver dw_mci_bluefield_pltfm_driver = {
> > +	.probe		= dw_mci_bluefield_probe,
> > +	.remove		= dw_mci_pltfm_remove,
> > +	.driver		= {
> > +		.name		= "dwmmc_bluefield",
> > +		.of_match_table	= dw_mci_bluefield_match,
> > +		.pm		= &dw_mci_pltfm_pmops,
> > +	},
> > +};
> > +
> > +module_platform_driver(dw_mci_bluefield_pltfm_driver);
> > +
> > +MODULE_DESCRIPTION("BlueField DW Multimedia Card driver");
> > +MODULE_AUTHOR("Mellanox Technologies");
> > +MODULE_LICENSE("GPL v2");
> >

  parent reply	other threads:[~2018-05-08 18:55 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 15:32 Liming Sun
2018-04-23 15:32 ` [PATCH v2 2/3] Documentation: bluefield-dw-mshc: add DT description Liming Sun
2018-04-27 19:50   ` Rob Herring
2018-04-30 14:57     ` Liming Sun
2018-04-23 15:32 ` [PATCH v2 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-04-24  1:11 ` [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension Shawn Lin
2018-05-08 13:06   ` Liming Sun
2018-05-08 18:55   ` Liming Sun [this message]
2018-04-30 14:51 ` [PATCH v3 " Liming Sun
2018-04-30 14:51 ` [PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 12:48   ` Rob Herring
2018-05-01 14:36     ` Liming Sun
2018-04-30 14:51 ` [PATCH v3 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-01 14:32 ` [PATCH v4 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-01 14:32 ` [PATCH v4 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 16:24   ` Rob Herring
2018-05-01 19:10     ` Liming Sun
2018-05-01 14:32 ` [PATCH v4 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-01 18:19 ` [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-02  1:02   ` Shawn Lin
2018-05-02 12:45     ` Liming Sun
2018-05-03  7:25       ` Shawn Lin
2018-05-03 14:35         ` Liming Sun
2018-05-02  8:16   ` Jaehoon Chung
2018-05-03 15:52     ` Liming Sun
2018-05-01 18:19 ` [PATCH v5 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-01 18:19 ` [PATCH v5 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-03 15:45 ` [PATCH v6 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-03 15:45 ` [PATCH v6 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-03 15:45 ` [PATCH v6 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-08 18:46 ` [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension Liming Sun
2018-05-09  1:45   ` Shawn Lin
2018-05-21 11:36   ` Ulf Hansson
2019-01-18 10:06   ` Thomas Gleixner
2018-05-08 18:46 ` [PATCH v7 2/3] dt-bindings: mmc: Add binding for BlueField SoC Liming Sun
2018-05-21 11:36   ` Ulf Hansson
2018-05-08 18:46 ` [PATCH v7 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver Liming Sun
2018-05-21 11:36   ` Ulf Hansson
2018-05-21 19:35     ` Liming Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB4PR05MB0768969F61B828B1B19A31DDA19A0@DB4PR05MB0768.eurprd05.prod.outlook.com \
    --to=lsun@mellanox.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will.deacon@arm.com \
    --subject='RE: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).