LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Subject: RE: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping
Date: Thu, 26 Apr 2018 10:22:49 +0000 [thread overview]
Message-ID: <DB6PR0401MB2536A4E804E84D417AD1398CF88E0@DB6PR0401MB2536.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20180426023308.aezdge7xlbqoe5at@localhost>
Hi Richard,
> -----Original Message-----
> From: Richard Cochran [mailto:richardcochran@gmail.com]
> Sent: Thursday, April 26, 2018 10:33 AM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Greg
> Kroah-Hartman <gregkh@linuxfoundation.org>; dan.carpenter@oracle.com;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Subject: Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
> timestamping
>
> On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
>
> > +/* PTP nominal frequency 1GHz */
> > +#define DPAA2_PTP_NOMINAL_FREQ_PERIOD_NS 1
>
> Nit: Frequency is the inverse of the period. It can be one or the other, not
> both.
>
> Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?
[Y.b. Lu] Thanks. Let me use DPAA2_PTP_CLK_PERIOD_NS in next version.
>
> You haven't implemented the ethtool_get_ts_info() method, but you need to
> do so. Show us how the user can related these MAC time stamps to the PHC
> device in your other patch series.
[Y.b. Lu] I will add patch for ethtool_get_ts_info in next version. Thanks!
But I'm not sure whether ethtool should show hw timestamping always ignoring phc enabled or not.
Actually the hw timestamping is supported always since ptp clock had been initialized in MC firmware.
Let me just send out the patch for reviewing.
>
> Thanks,
> Richard
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-04-26 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 9:17 Yangbo Lu
2018-04-25 10:03 ` Dan Carpenter
2018-04-26 10:17 ` Y.b. Lu
2018-04-26 2:33 ` Richard Cochran
2018-04-26 10:22 ` Y.b. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0401MB2536A4E804E84D417AD1398CF88E0@DB6PR0401MB2536.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richardcochran@gmail.com \
--subject='RE: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).