RE: [PATCH v2] rtc: da9063: add as wakeup source

[Adam Thomson <Adam.Thomson.Opensource@diasemi.com>]

On 23 November 2021 14:06, Nikita Shubin wrote:

> As da9063 driver refuses to load without irq, we simply add it as a wakeup
> source before registering rtc device.

Can you please make the commit message more detailed, explaining why you're
making this change; what it adds/fixes/removes/etc.? Right now just reading this
I'm unclear as to why you're adding a call to device_init_wakeup() here. The
generic I2C client code will mark the parent MFD device as a wake source, if
the relevant boolean 'wakeup' is defined in DT, so what does this add?

> 
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> v1->v2:
> Alexandre Belloni:
> 
> Dropped everything except device_init_wakeup, as driver refuses to load
> without irq specified, we can always set it as a wakeup source, before
> calling devm_rtc_register_device.
> ---
>  drivers/rtc/rtc-da9063.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
> index d4b72a9fa2ba..b9a73356bace 100644
> --- a/drivers/rtc/rtc-da9063.c
> +++ b/drivers/rtc/rtc-da9063.c
> @@ -494,6 +494,8 @@ static int da9063_rtc_probe(struct platform_device
> *pdev)
>  		dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
>  			irq_alarm, ret);
> 
> +	device_init_wakeup(&pdev->dev, true);
> +
>  	return devm_rtc_register_device(rtc->rtc_dev);
>  }
> 
> --
> 2.31.1