LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: David Abdurachmanov <david.abdurachmanov@sifive.com>,
	Support Opensource <Support.Opensource@diasemi.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rtc: da9063: add as wakeup source
Date: Tue, 23 Nov 2021 14:37:42 +0000	[thread overview]
Message-ID: <DB9PR10MB465224854946DABA0F75515980609@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211123140604.21655-1-nikita.shubin@maquefel.me>

On 23 November 2021 14:06, Nikita Shubin wrote:

> As da9063 driver refuses to load without irq, we simply add it as a wakeup
> source before registering rtc device.

Can you please make the commit message more detailed, explaining why you're
making this change; what it adds/fixes/removes/etc.? Right now just reading this
I'm unclear as to why you're adding a call to device_init_wakeup() here. The
generic I2C client code will mark the parent MFD device as a wake source, if
the relevant boolean 'wakeup' is defined in DT, so what does this add?

> 
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> v1->v2:
> Alexandre Belloni:
> 
> Dropped everything except device_init_wakeup, as driver refuses to load
> without irq specified, we can always set it as a wakeup source, before
> calling devm_rtc_register_device.
> ---
>  drivers/rtc/rtc-da9063.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
> index d4b72a9fa2ba..b9a73356bace 100644
> --- a/drivers/rtc/rtc-da9063.c
> +++ b/drivers/rtc/rtc-da9063.c
> @@ -494,6 +494,8 @@ static int da9063_rtc_probe(struct platform_device
> *pdev)
>  		dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
>  			irq_alarm, ret);
> 
> +	device_init_wakeup(&pdev->dev, true);
> +
>  	return devm_rtc_register_device(rtc->rtc_dev);
>  }
> 
> --
> 2.31.1


  reply	other threads:[~2021-11-23 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 14:06 Nikita Shubin
2021-11-23 14:37 ` Adam Thomson [this message]
2021-11-26  9:09   ` Nikita Shubin
2021-11-26  9:50     ` Adam Thomson
2021-11-26 10:23       ` Nikita Shubin
2021-11-26 11:14         ` Adam Thomson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB9PR10MB465224854946DABA0F75515980609@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM \
    --to=adam.thomson.opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=david.abdurachmanov@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=nikita.shubin@maquefel.me \
    --subject='RE: [PATCH v2] rtc: da9063: add as wakeup source' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).