LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: David Abdurachmanov <david.abdurachmanov@sifive.com>,
	Support Opensource <Support.Opensource@diasemi.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rtc: da9063: add as wakeup source
Date: Fri, 26 Nov 2021 11:14:32 +0000	[thread overview]
Message-ID: <DB9PR10MB46522773A37F67052B6BECE180639@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211126132308.7b265f17@redslave.neermore.group>

On 26 November 2021 10:23, Nikita Shubin wrote:

> > Thanks for the detailed response; it helped a lot. Having reviewed
> > the core code along with your description I know understand what's
> > happening here. Basically marking as 'wakeup-source' is simply a
> > means to expose the sysfs attribute to user-space.
> >
> > Yes I think in the commit message you should be clear that there's a
> > need to access the sys attribute 'wakealarm' in the RTC core and
> > clarify exactly why there is that need. Your commit log should be
> > good enough so that if anyone else needs to look at this later they
> > completely understand the intention behind the change.
> >
> > By the way, I assume the functionality you're looking for could also
> > have been achieved through using the /dev/rtcX instance for DA9063?
> 
> Thank you for pointing this out, indeed i missed that obvious thing.
> 
> We can also simply set alarm via rtcwake, even if CONFIG_PM is off:
> 
> rtcwake -m no -s 60
> 
> Now i am not sure we should make changes to da9063-rtc driver - what do
> you think ?

I think the change is still valid from what I can tell. Just be clear on intent
in the commit log of the patch. :)

      reply	other threads:[~2021-11-26 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 14:06 Nikita Shubin
2021-11-23 14:37 ` Adam Thomson
2021-11-26  9:09   ` Nikita Shubin
2021-11-26  9:50     ` Adam Thomson
2021-11-26 10:23       ` Nikita Shubin
2021-11-26 11:14         ` Adam Thomson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB9PR10MB46522773A37F67052B6BECE180639@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM \
    --to=adam.thomson.opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=david.abdurachmanov@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=nikita.shubin@maquefel.me \
    --subject='RE: [PATCH v2] rtc: da9063: add as wakeup source' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).