LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Alon Bar-Lev <alon.barlev@gmail.com>,
	Bernhard Walle <bwalle@suse.de>,
	linux-kernel@vger.kernel.org,
	Alon Bar-Lev <alon.barlev@gmail.com>
Subject: Re: [patch 03/26] Dynamic kernel command-line - arm
Date: Thu, 18 Jan 2007 20:56:18 +0100	[thread overview]
Message-ID: <E1H7dMw-0000hd-H6@be1.lrz> (raw)
In-Reply-To: <7EGKC-5vh-15@gated-at.bofh.it>

Alon Bar-Lev <alon.barlev@gmail.com> wrote:
> On 1/18/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
>> > 2. Set command_line as __initdata.

>> You can't.
>>
>> > -static char command_line[COMMAND_LINE_SIZE];
>> > +static char __initdata command_line[COMMAND_LINE_SIZE];
>>
>> Uninitialised data is placed in the BSS.  Adding __initdata to BSS
>> data causes grief.

> There are many places in kernel that uses __initdata for uninitialized
> variables.
> 
> For example:

> static int __initdata is_chipset_set[MAX_HWIFS];
> 
> So all these current places are wrong?
> If I initialize the data will it be OK.

objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed
into .init.data here, not into .bss.
-- 
Top 100 things you don't want the sysadmin to say:
92. What software license?

Friß, Spammer: kq@izs.zi.7eggert.dyndns.org P-@aPN2Oo0.7eggert.dyndns.org

       reply	other threads:[~2007-01-18 20:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7EFbN-34r-3@gated-at.bofh.it>
     [not found] ` <7EFbV-34r-45@gated-at.bofh.it>
     [not found]   ` <7EGhI-4Rq-11@gated-at.bofh.it>
     [not found]     ` <7EGKC-5vh-15@gated-at.bofh.it>
2007-01-18 19:56       ` Bodo Eggert [this message]
2007-01-22 11:38         ` Alon Bar-Lev
2007-01-18 12:58 [patch 00/26] Dynamic kernel command-line Bernhard Walle
2007-01-18 12:58 ` [patch 03/26] Dynamic kernel command-line - arm Bernhard Walle
2007-01-18 14:14   ` Russell King
2007-01-18 14:48     ` Alon Bar-Lev
2007-01-18 15:31     ` Tomas Carnecky
2007-01-18 15:23       ` Russell King
2007-01-18 15:31         ` Alon Bar-Lev
2007-01-19 12:38         ` Bernhard Walle
2007-01-22 19:56         ` Andrew Morton
2007-01-22 20:00           ` Russell King
2007-01-22 20:31           ` Alon Bar-Lev
2007-01-22 20:44             ` Andrew Morton
2007-01-22 20:58               ` Bernhard Walle
2007-01-22 21:02                 ` Alon Bar-Lev
2007-01-22 22:14         ` Bernhard Walle
2007-01-22 22:27           ` Russell King
2007-01-22 22:42             ` Bernhard Walle
2007-01-23 10:37             ` Alon Bar-Lev
2007-01-23 10:41               ` Russell King
2007-01-23 10:50                 ` Alon Bar-Lev
2007-01-23 10:53                   ` Russell King
2007-01-23 10:59                     ` Alon Bar-Lev
2007-01-23 11:31                     ` Alon Bar-Lev
2007-01-23 11:54                       ` Russell King
2007-01-23 11:59                         ` Alon Bar-Lev
2007-01-23 12:43                           ` Russell King
  -- strict thread matches above, loose matches on Subject: below --
2006-12-02 10:47 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-12-02 10:49 ` [PATCH 03/26] Dynamic kernel command-line - arm Alon Bar-Lev
2006-09-03 22:15 [PATCH 00/26] Dynamic kernel command-line - Resend please ignore last Alon Bar-Lev
2006-09-03 22:17 ` [PATCH 03/26] Dynamic kernel command-line - arm Alon Bar-Lev
2006-09-03 21:50 [PATCH 00/26] Dynamic kernel command-line Alon Bar-Lev
2006-09-03 21:53 ` [PATCH 03/26] Dynamic kernel command-line - arm Alon Bar-Lev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1H7dMw-0000hd-H6@be1.lrz \
    --to=7eggert@gmx.de \
    --cc=alon.barlev@gmail.com \
    --cc=bwalle@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [patch 03/26] Dynamic kernel command-line - arm' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).