LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>,
	Andrew Morton <akpm@osdl.org>, Martin Peschke <mp3@de.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class_old inside flags
Date: Sat, 27 Jan 2007 13:01:08 +0100	[thread overview]
Message-ID: <E1HAmF2-0000cV-Ux@be1.lrz> (raw)
In-Reply-To: <7HR6S-3Wm-13@gated-at.bofh.it>

Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:

> The new/old ra class were implicitly stored in low bits of
> file_ra_state.flags. Now make the data structure obvious, and remove the
> coding tricks.

> +++ linux-2.6.20-rc4-mm1/include/linux/fs.h

> -     unsigned long flags;    /* RA_FLAG_xxx | ra_class_old | ra_class_new */
> +     union {
> +             unsigned long   flags;  /* RA_FLAG_xxx | class_old | class_new */
> +             struct {
> +                     u8      class_new;
> +                     u8      class_old;

This doesn't work on big endiam machines, does it?

IMO you should use a bitfield instead.
-- 
Your e-mail has been returned due to insufficient voltage. 

Friß, Spammer: aegzcH4Js@luevh-7.7eggert.dyndns.org
 ptulV7@C.7eggert.dyndns.org vkIfyB@SEcltba.7eggert.dyndns.org

       reply	other threads:[~2007-01-27 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7HR6P-3Wm-3@gated-at.bofh.it>
     [not found] ` <7HR6S-3Wm-13@gated-at.bofh.it>
2007-01-27 12:01   ` Bodo Eggert [this message]
2007-01-28 19:11     ` Randy Dunlap
2007-01-27  8:02 [PATCH 0/8] readahead updates Fengguang Wu
     [not found] ` <369886263.27547@ustc.edu.cn>
2007-01-27  8:02   ` [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class_old inside flags Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HAmF2-0000cV-Ux@be1.lrz \
    --to=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mp3@de.ibm.com \
    --cc=wfg@mail.ustc.edu.cn \
    --subject='Re: [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class_old inside flags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).