LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Dave Jones <davej@redhat.com>, Dave Jones <davej@redhat.com>,
	jmoyer@redhat.com, Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Fernandez <sfernand@redhat.com>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] raw: don't allow the creation of a raw device with minor number 0
Date: Tue, 30 Jan 2007 16:52:08 +0100	[thread overview]
Message-ID: <E1HBvHE-000165-9r@be1.lrz> (raw)
In-Reply-To: <7IoP7-5nQ-13@gated-at.bofh.it>

Dave Jones <davej@redhat.com> wrote:
> On Fri, Jan 12, 2007 at 05:58:41PM -0500, jmoyer@redhat.com wrote:

>  > jengelh>   What:   RAW driver (CONFIG_RAW_DRIVER)
>  > jengelh>   When:   December 2005
>  > jengelh>   Why:    declared obsolete since kernel 2.6.3
>  > jengelh>           O_DIRECT can be used instead
>  > jengelh>   Who:    Adrian Bunk <bunk@stusta.de>
>  > 
>  > It's still present, still used, and so would benefit from being fixed, in
>  > my opinion.

ACK, it's a bug, the patch is there, and AFAIR it's simple and correct. Maybe
it is suitable for the stable branch, too. If the RAW driver isn't removed,
it should be applied.

> Given the tirade against O_DIRECT on linux-kernel earlier this month,
> it has me wondering about the validity of this entry.

O_DIRECT on devices is accepted by Linus, since it has much less corner
cases.

> Every time we've tried to deprecate this driver in Fedora/RHEL, we've
> had enough people complain that we've ended up having to turn it back on.
> (And I'm fairly sure other distros have been in the same position).
> Some vendors seem way too attached to the older semantics than having
> to rewrite their apps to use O_DIRECT, and unnecessarily breaking them
> so that we can throw away a 306 line driver in the name of cleanliness
> seems a bit gratuitous.

It must be hard to add #ifndef O_DIRECT / #define O_DIRECT 0 / #endif
and to add O_DIRECT to the apropiate open calls ...

(I peeked into the driver, and it seems it's just a wrapper creating an alias
 and opening the associated block-device O_DIRECT.)
-- 
We are all born ignorant, but one must work hard to remain stupid.
        -- Benjamin Franklin

Friß, Spammer: zOfbszC@c7h.7eggert.dyndns.org dr@mnpqOUpA.7eggert.dyndns.org

       reply	other threads:[~2007-01-30 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7CxBM-2pk-23@gated-at.bofh.it>
     [not found] ` <7CDnP-30W-9@gated-at.bofh.it>
     [not found]   ` <7CDxA-3cL-9@gated-at.bofh.it>
     [not found]     ` <7IoP7-5nQ-13@gated-at.bofh.it>
2007-01-30 15:52       ` Bodo Eggert [this message]
2007-01-12 16:32 Jeff Moyer
2007-01-12 22:41 ` Jan Engelhardt
2007-01-12 22:58   ` jmoyer
2007-01-28 20:23     ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HBvHE-000165-9r@be1.lrz \
    --to=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfernand@redhat.com \
    --subject='Re: [patch] raw: don'\''t allow the creation of a raw device with minor number 0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).