LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	stable@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] kbuild: fix dependency generation
Date: Sun, 1 Apr 2007 17:51:05 +0200	[thread overview]
Message-ID: <E1HY2Kf-0002QC-O3@flower> (raw)
In-Reply-To: <20070401104551.GA7560@uranus.ravnborg.org>

> From: Sam Ravnborg
> Newsgroups: gmane.linux.kernel
> Subject: [PATCH] kbuild: fix dependency generation
> Date: Sun, 1 Apr 2007 12:45:51 +0200
>
[]
>  scripts/basic/fixdep.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
> index 668a11a..24144a2 100644
> --- a/scripts/basic/fixdep.c
> +++ b/scripts/basic/fixdep.c
> @@ -28,9 +28,11 @@
>   * the dependency on linux/autoconf.h by a dependency on every config
>   * option which is mentioned in any of the listed prequisites.
>   *
> - * To be exact, split-include populates a tree in include/config/,
> - * e.g. include/config/his/driver.h, which contains the #define/#undef
> - * for the CONFIG_HIS_DRIVER option.
> + * kconfig populates a tree in include/config/ with an empty file
> + * for each config symbol and when the configuration is updated
> + * the files representing changed config options are touched
> + * which thern let make pick up the changes and the files that uses
            ^ then?                                               ^ use?
> + * the config symbols are rebuild.
                             ^ rebuilt?

Just in case that's wrong (IANALang, of course :)

>   *
>   * So if the user changes his CONFIG_HIS_DRIVER option, only the objects
>   * which depend on "include/linux/config/his/driver.h" will be rebuilt,
> @@ -245,6 +247,8 @@ void parse_config_file(char *map, size_t len)
>  		continue;
>  
>  	found:
> +		if (!memcmp(q - 7, "_MODULE", 7))
> +			q -= 7;
>  		use_config(p+7, q-p-7);
>  	}
>  }
> -- 
> 1.5.1.rc3.20.gaa453
>
____

  reply	other threads:[~2007-04-01 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01 10:45 Sam Ravnborg
2007-04-01 15:51 ` Oleg Verych [this message]
2007-04-01 18:41   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HY2Kf-0002QC-O3@flower \
    --to=olecom@flower.upol.cz \
    --cc=akpm@osdl.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: [PATCH] kbuild: fix dependency generation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).