LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: torvalds@linux-foundation.org
Cc: miklos@szeredi.hu, peterz@infradead.org, salikhmetov@gmail.com,
linux-mm@kvack.org, jakob@unthought.net,
linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu,
riel@redhat.com, ksm@42.dk, staubach@redhat.com,
jesper.juhl@gmail.com, akpm@linux-foundation.org,
protasnb@gmail.com, r.e.wolff@bitwizard.nl,
hidave.darkstar@gmail.com, hch@infradead.org
Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files
Date: Fri, 18 Jan 2008 19:57:17 +0100 [thread overview]
Message-ID: <E1JFwOz-00019k-Uo@pomaz-ex.szeredi.hu> (raw)
In-Reply-To: <alpine.LFD.1.00.0801181033580.2957@woody.linux-foundation.org> (message from Linus Torvalds on Fri, 18 Jan 2008 10:43:35 -0800 (PST))
> > That would need a new page flag (PG_mmap_dirty?). Do we have one
> > available?
>
> Yeah, that would be bad. We probably have flags free, but those page flags
> are always a pain. Scratch that.
>
> How about just setting a per-vma dirty flag, and then instead of updating
> the mtime when taking the dirty-page fault, we just set that flag?
>
> Then, on unmap and msync, we just do
>
> if (vma->dirty-flag) {
> vma->dirty_flag = 0;
> update_file_times(vma->vm_file);
> }
>
> and be done with it?
But then background writeout, sync(2), etc, wouldn't update the times.
Dunno. I don't think actual _physical_ writeout matters much, so it's
not worse to be 30s early with the timestamp, than to be 30s or more
late.
Miklos
next prev parent reply other threads:[~2008-01-18 18:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 22:31 [PATCH -v6 0/2] Fixing the issue with memory-mapped file times Anton Salikhmetov
2008-01-17 22:31 ` [PATCH -v6 1/2] Massive code cleanup of sys_msync() Anton Salikhmetov
2008-01-18 9:33 ` Miklos Szeredi
2008-01-18 10:30 ` Anton Salikhmetov
2008-01-17 22:31 ` [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files Anton Salikhmetov
2008-01-18 9:51 ` Miklos Szeredi
2008-01-18 10:15 ` Peter Zijlstra
2008-01-18 10:25 ` Peter Zijlstra
2008-01-18 10:39 ` Anton Salikhmetov
2008-01-18 17:58 ` Linus Torvalds
2008-01-18 18:11 ` Miklos Szeredi
2008-01-18 18:28 ` Rik van Riel
2008-01-18 18:51 ` Miklos Szeredi
2008-01-18 18:43 ` Linus Torvalds
2008-01-18 18:57 ` Miklos Szeredi [this message]
2008-01-18 19:08 ` Linus Torvalds
2008-01-18 19:22 ` Miklos Szeredi
2008-01-18 19:35 ` Linus Torvalds
2008-01-18 19:58 ` Anton Salikhmetov
2008-01-18 20:22 ` Linus Torvalds
2008-01-18 21:03 ` Anton Salikhmetov
2008-01-18 21:27 ` Linus Torvalds
2008-01-18 22:04 ` Anton Salikhmetov
2008-01-18 22:21 ` Linus Torvalds
2008-01-18 22:35 ` Anton Salikhmetov
2008-01-18 22:32 ` Ingo Oeser
2008-01-18 22:47 ` Linus Torvalds
2008-01-18 22:54 ` Rik van Riel
2008-01-19 0:50 ` Matt Mackall
2008-01-19 4:25 ` Rik van Riel
2008-01-19 10:22 ` Miklos Szeredi
2008-01-19 15:49 ` Matt Mackall
2008-01-21 14:25 ` Peter Staubach
2008-01-21 14:36 ` Anton Salikhmetov
2008-01-18 10:38 ` Miklos Szeredi
2008-01-18 11:00 ` Peter Zijlstra
2008-01-18 11:17 ` Miklos Szeredi
2008-01-18 11:23 ` Peter Zijlstra
2008-01-18 11:36 ` Miklos Szeredi
2008-01-18 9:40 ` [PATCH -v6 0/2] Fixing the issue with memory-mapped file times Miklos Szeredi
2008-01-18 10:31 ` Anton Salikhmetov
2008-01-18 19:48 ` Anton Salikhmetov
2008-01-19 10:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JFwOz-00019k-Uo@pomaz-ex.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=jakob@unthought.net \
--cc=jesper.juhl@gmail.com \
--cc=ksm@42.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=protasnb@gmail.com \
--cc=r.e.wolff@bitwizard.nl \
--cc=riel@redhat.com \
--cc=salikhmetov@gmail.com \
--cc=staubach@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=valdis.kletnieks@vt.edu \
--subject='Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).