LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Ryo Tsuruta <ryov@valinux.co.jp>
Cc: containers@lists.linux-foundation.org, dm-devel@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH 1/2] dm-band: The I/O bandwidth controller: Source code  patch
Date: Wed, 23 Jan 2008 14:33:28 +0100	[thread overview]
Message-ID: <E1JHfjM-0003NV-BR@faramir.fjphome.nl> (raw)
In-Reply-To: <20080123.215632.226773739.ryov@valinux.co.jp>

Hi,

I'm not qualified to comment on the code, but here are some suggestions on
config option and comments.

Cheers,
FJP

Ryo Tsuruta wrote:
> +config DM_BAND
> +	tristate "I/O band width control "

s/band width/bandwidth/
(it seems to be used correctly elsewhere, but you may want to double-check)

> +	depends on BLK_DEV_DM
> +	---help---
> +	Any processes or cgroups can use the same storage
> +	with its band-width fairly shared.

s/band-width/bandwidth/

The help should probably be a bit more verbose as this does not tell anybody
much who has not already read the documentation.

Maybe something like:
<snip>
This device-mapper target allows to define how the
available bandwith of a storage device should be
shared between processes or cgroups.

Information on how to use dm-band is available in:
   Documentation/device-mapper/band.txt
</snip>

> + * The following functiotons determine when and which BIOs should
                    ^^^^^^^^^^^
> + * be submitted to control the I/O flow.
> + * It is possible to add a new I/O scheduling policy with it.

> + *  <Method>      <description>
> + * g_can_submit   : To determine whether a given group has a right to

s/a right/the right/

> + *                  submit BIOs.
> + * 		    The larger return value the higher priority to submit.
> + * 		    Zero means it has no right.

"The larger the return value, the higher the priority [...]"

> + * g_prepare_bio  : Called right before submitting each BIO.
> + * g_restart_bios : Called when there exist some BIOs blocked but none of
> them
> + * 		    can't be submitted now.

s/when there exist some BIOs blocked/if some BIOs exist that are blocked/ ?

"none of them can't" : the double negative looks incorrect (and should be
avoided anyway)

> + *		    This method have to do something to restart to submit BIOs.

s/have/has/

"has to do something" : that's rather vague...

  reply	other threads:[~2008-01-23 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 12:53 [PATCH 0/2] dm-band: The I/O bandwidth controller: Overview Ryo Tsuruta
2008-01-23 12:56 ` [PATCH 1/2] dm-band: The I/O bandwidth controller: Source code patch Ryo Tsuruta
2008-01-23 13:33   ` Frans Pop [this message]
2008-01-23 15:48     ` Ryo Tsuruta
2008-01-27 15:44     ` Frans Pop
2008-01-23 12:58 ` [PATCH 2/2] dm-band: The I/O bandwidth controller: Document Ryo Tsuruta
2008-01-23 19:57   ` Andi Kleen
2008-01-24 10:32     ` Ryo Tsuruta
2008-01-23 14:32 ` [PATCH 0/2] dm-band: The I/O bandwidth controller: Overview Peter Zijlstra
2008-01-23 17:25   ` Ryo Tsuruta
2008-01-23 14:47 ` [dm-devel] " Alasdair G Kergon
2008-01-23 16:21   ` Hirokazu Takahashi
2008-01-24  3:38     ` YAMAMOTO Takashi
2008-01-24 10:14       ` Hirokazu Takahashi
2008-01-25  6:26         ` YAMAMOTO Takashi
2008-01-25  7:07 ` dm-band: The I/O bandwidth controller: Performance Report Ryo Tsuruta
2008-01-29  6:42   ` [Xen-devel] " INAKOSHI Hiroya
2008-01-30  3:32     ` Ryo Tsuruta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JHfjM-0003NV-BR@faramir.fjphome.nl \
    --to=elendil@planet.nl \
    --cc=containers@lists.linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryov@valinux.co.jp \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    --subject='Re: [PATCH 1/2] dm-band: The I/O bandwidth controller: Source code  patch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).