LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@linux-foundation.org
Cc: miklos@szeredi.hu, a.p.zijlstra@chello.nl,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, kay.sievers@vrfy.org, greg@kroah.com,
	trond.myklebust@fys.uio.no
Subject: Re: [patch 2/6] mm: bdi: export BDI attributes in sysfs
Date: Thu, 31 Jan 2008 10:39:02 +0100	[thread overview]
Message-ID: <E1JKVss-0001yr-7A@pomaz-ex.szeredi.hu> (raw)
In-Reply-To: <20080130162839.977d1e63.akpm@linux-foundation.org> (message from Andrew Morton on Wed, 30 Jan 2008 16:28:39 -0800)

> On Tue, 29 Jan 2008 16:49:02 +0100
> Miklos Szeredi <miklos@szeredi.hu> wrote:
> 
> > From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > 
> > Provide a place in sysfs (/sys/class/bdi) for the backing_dev_info
> > object.  This allows us to see and set the various BDI specific
> > variables.
> > 
> > In particular this properly exposes the read-ahead window for all
> > relevant users and /sys/block/<block>/queue/read_ahead_kb should be
> > deprecated.
> 
> This description is not complete.  It implies that the readahead window is
> not "properly" exposed for some "relevant" users.  The reader is left
> wondering what on earth this is referring to.  I certainly don't know.
> Perhaps when this information is revealed, we can work out what was
> wrong with per-queue readahead tuning.

I think Peter meant, that the readahead window was only exposed for
block devices, and not things like NFS or FUSE.

> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ linux/Documentation/ABI/testing/sysfs-class-bdi	2008-01-29 13:02:46.000000000 +0100
> > @@ -0,0 +1,50 @@
> > +What:		/sys/class/bdi/<bdi>/
> > +Date:		January 2008
> > +Contact:	Peter Zijlstra <a.p.zijlstra@chello.nl>
> > +Description:
> > +
> > +Provide a place in sysfs for the backing_dev_info object.
> > +This allows us to see and set the various BDI specific variables.
> > +
> > +The <bdi> identifyer can take the following forms:
> 
> "identifier"

Arrgh.  Must run spellchecker on doc files :)

> > +blk-NAME
> > +
> > +	Block devices, NAME is 'sda', 'loop0', etc...
> 
> But if I've done `mknod /dev/pizza-party 8 0', I'm looking for
> blk-pizza-party, not blk-sda.
> 
> But I might still have /dev/sda, too.

An alternative would be to uniformly use MAJOR:MINOR in there.  It
would work for block devices and anonymous devices (NFS/FUSE) as well.

Would that be any better?

> 
> > +FSTYPE-MAJOR:MINOR
> > +
> > +	Non-block device backed filesystems which provide their own
> > +	BDI, such as NFS and FUSE.  MAJOR:MINOR is the value of st_dev
> > +	for files on this filesystem.
> > +
> > +default
> > +
> > +	The default backing dev, used for non-block device backed
> > +	filesystems which do not provide their own BDI.
> > +
> > +Files under /sys/class/bdi/<bdi>/
> > +---------------------------------
> > +
> > +read_ahead_kb (read-write)
> > +
> > +	Size of the read-ahead window in kilobytes
> > +
> > +reclaimable_kb (read-only)
> > +
> > +	Reclaimable (dirty or unstable) memory destined for writeback
> > +	to this device
> > +
> > +writeback_kb (read-only)
> > +
> > +	Memory currently under writeback to this device
> > +
> > +dirty_kb (read-only)
> > +
> > +	Global threshold for reclaimable + writeback memory
> > +
> > +bdi_dirty_kb (read-only)
> > +
> > +	Current threshold on this BDI for reclaimable + writeback
> > +	memory
> > +
> 
> I dunno.  A number of the things which you're exposing are closely tied to
> present-day kernel implementation and may be irrelevant or even
> unimplementable in a few years' time.

Which ones?  They could possibly be moved to debugfs, or something.

I agree, that sysfs should be relatively stable.

Thanks,
Miklos

  reply	other threads:[~2008-01-31  9:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 15:49 [patch 0/6] mm: bdi: updates Miklos Szeredi
2008-01-29 15:49 ` [patch 1/6] mm: bdi: tweak task dirty penalty Miklos Szeredi
2008-01-31  0:13   ` Andrew Morton
2008-01-29 15:49 ` [patch 2/6] mm: bdi: export BDI attributes in sysfs Miklos Szeredi
2008-01-29 17:39   ` Greg KH
2008-01-31  0:28   ` Andrew Morton
2008-01-31  9:39     ` Miklos Szeredi [this message]
2008-01-31  9:54       ` Andrew Morton
2008-01-31 10:08         ` Peter Zijlstra
2008-02-29 11:26   ` Andrew Morton
2008-01-29 15:49 ` [patch 3/6] mm: bdi: expose the BDI object in sysfs for NFS Miklos Szeredi
2008-01-29 15:49 ` [patch 4/6] mm: bdi: expose the BDI object in sysfs for FUSE Miklos Szeredi
2008-01-29 15:49 ` [patch 5/6] mm: bdi: allow setting a minimum for the bdi dirty limit Miklos Szeredi
2008-01-29 15:49 ` [patch 6/6] mm: bdi: allow setting a maximum " Miklos Szeredi
2008-01-31  0:39   ` Andrew Morton
2008-01-31  9:46     ` Miklos Szeredi
2008-01-31 10:17       ` Peter Zijlstra
2008-01-29 17:06 ` [patch 0/6] mm: bdi: updates Peter Zijlstra
2008-01-29 18:32   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JKVss-0001yr-7A@pomaz-ex.szeredi.hu \
    --to=miklos@szeredi.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=trond.myklebust@fys.uio.no \
    --subject='Re: [patch 2/6] mm: bdi: export BDI attributes in sysfs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).