LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Denis Cheng <crquan@gmail.com>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide-core: remove conditional compiling with MODULE in ide-core.c
Date: Sat, 02 Feb 2008 19:58:15 +0100	[thread overview]
Message-ID: <E1JLNZ9-0000iB-G8@be1.7eggert.dyndns.org> (raw)
In-Reply-To: <9Slso-6q4-5@gated-at.bofh.it>

Denis Cheng <crquan@gmail.com> wrote:

> use module_init/module_exit to replace the original cond-compiling, these
> macros were well designed to deal module/built-in compiling.
> 
> the original __setup with null string was invalid and not executed,
> __setup("", ide_setup);
> 
> however, with the current module_param mechanics, module parameters also can
> be input on the kernel command line, with this style:
> 
> ide-core.options="ide=nodma hdd=cdrom idebus=..."
> 
> so Documentation/kernel-parameters.txt also updated.

> --- a/Documentation/kernel-parameters.txt

> -     ide=            [HW] (E)IDE subsystem
> -                     Format: ide=nodma or ide=doubler or ide=reverse
> -                     See Documentation/ide.txt.
> -
> -     ide?=           [HW] (E)IDE subsystem
> -                     Format: ide?=noprobe or chipset specific parameters.
> -                     See Documentation/ide.txt.
> -
> -     idebus=         [HW] (E)IDE subsystem - VLB/PCI bus speed
> +     ide-core.options= [HW] (E)IDE subsystem
> +                     Format: ide-core.options="ide=nodma hdd=cdrom idebus=..."

IMO you should use separate options for things like nodma while you're at it.

¢¢


       reply	other threads:[~2008-02-02 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9Slso-6q4-5@gated-at.bofh.it>
2008-02-02 18:58 ` Bodo Eggert [this message]
2008-02-02  7:52 Denis Cheng
2008-02-06 22:22 ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JLNZ9-0000iB-G8@be1.7eggert.dyndns.org \
    --to=7eggert@gmx.de \
    --cc=bzolnier@gmail.com \
    --cc=crquan@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] ide-core: remove conditional compiling with MODULE in ide-core.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).