LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr
@ 2008-02-23 17:56 Laura Garcia
  2008-02-24  5:11 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Garcia @ 2008-02-23 17:56 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel

Use register offset definition for WOLcgClr. This patch does not 
change the driver behaviour.

Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>

	modified:   drivers/net/via-rhine.c
---
 drivers/net/via-rhine.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c
index 7c851b1..8c9d6ae 100644
--- a/drivers/net/via-rhine.c
+++ b/drivers/net/via-rhine.c
@@ -1893,7 +1893,7 @@ static void rhine_shutdown (struct pci_dev *pdev)
 
 	/* Make sure we use pattern 0, 1 and not 4, 5 */
 	if (rp->quirks & rq6patterns)
-		iowrite8(0x04, ioaddr + 0xA7);
+		iowrite8(0x04, ioaddr + WOLcgClr);
 
 	if (rp->wolopts & WAKE_MAGIC) {
 		iowrite8(WOLmagic, ioaddr + WOLcrSet);
-- 
1.5.3.8


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr
  2008-02-23 17:56 [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr Laura Garcia
@ 2008-02-24  5:11 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-02-24  5:11 UTC (permalink / raw)
  To: Laura Garcia; +Cc: netdev, linux-kernel

Laura Garcia wrote:
> Use register offset definition for WOLcgClr. This patch does not 
> change the driver behaviour.
> 
> Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
> 
> 	modified:   drivers/net/via-rhine.c
> ---
>  drivers/net/via-rhine.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied, after making the following manual edits:

- removed "modified: ..." line, that is redundant to the diffstat, and 
being before the "---" separator, it is included in the changelog by 
automated tools

- removed all the silly dashes from the subject line.  we want something 
readable, not a filename.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-24  5:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-23 17:56 [PATCH 1/2]via-rhine.c: Use-register-offset-definition-for-WOLcgClr Laura Garcia
2008-02-24  5:11 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).