LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bodo Eggert  <arcoristkaputtundbrauchtdiesentext.7eggert@nurfuerspam.de>
To: Tao Ma <tm@tao.ma>,
	linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] loop: clear read-only flag in loop_clr_fd.
Date: Sun, 13 Feb 2011 21:41:51 +0100	[thread overview]
Message-ID: <E1PoilV-0002pC-6Z@be1.7eggert.dyndns.org> (raw)
In-Reply-To: <glHQm-1vQ-25@gated-at.bofh.it>

Tao Ma <tm@tao.ma> wrote:

> --- a/drivers/block/loop.c

> -     if (bdev)
> +     if (bdev) {
> +             set_device_ro(bdev, 0);
>  invalidate_bdev(bdev);
> +     }
>  set_capacity(lo->lo_disk, 0);
>  loop_sysfs_exit(lo);
>  if (bdev) {

This looks like set_device_ro() should imply invalidate_bdev().
-- 
E.G.G.E.R.T.: Electronic Guardian Generated for 
              Efficient Repair and Troubleshooting
        -- http://www.brunching.com/toys/toy-cyborger.html (down)
Friß, Spammer: PanIhbEe3@y.7eggert.dyndns.org iNEC@zy1oe.7eggert.dyndns.org


       reply	other threads:[~2011-02-13 20:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <glzzr-4Jt-1@gated-at.bofh.it>
     [not found] ` <glHQm-1vQ-25@gated-at.bofh.it>
2011-02-13 20:41   ` Bodo Eggert [this message]
2011-02-13  2:02 block device read-only handling regression in 2.6.38-rc4 (bisected) Milan Broz
2011-02-13 10:58 ` [PATCH] loop: clear read-only flag in loop_clr_fd Tao Ma
2011-02-13 14:11   ` Milan Broz
2011-02-13 15:05     ` Tao Ma
2011-02-13 16:44       ` Milan Broz
2011-02-14 10:30         ` Tejun Heo
2011-02-14 11:47           ` Milan Broz
2011-02-14 14:07             ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PoilV-0002pC-6Z@be1.7eggert.dyndns.org \
    --to=arcoristkaputtundbrauchtdiesentext.7eggert@nurfuerspam.de \
    --cc=7eggert@nurfuerspam.de \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=tm@tao.ma \
    --subject='Re: [PATCH] loop: clear read-only flag in loop_clr_fd.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).