LKML Archive on
help / color / mirror / Atom feed
From: Mark Brown <>
To: Kirill Marinushkin <>
Cc: Pierre-Louis Bossart <>,
	Jaroslav Kysela <>, Takashi Iwai <>,
	Mark Brown <>,
	Pan Xiuli <>,
	Liam Girdwood <>,,,
	Mark Brown <>, Mark Brown <>,, Takashi Iwai <>,
	Pan Xiuli <>,
	Pierre-Louis Bossart <>,,
	Liam Girdwood <>,
Subject: Applied "ASoC: topology: Add definitions for mclk_direction values" to the asoc tree
Date: Mon, 16 Apr 2018 18:15:24 +0100	[thread overview]
Message-ID: <E1f87iu-0002wh-VJ@debutante> (raw)
In-Reply-To: <>

The patch

   ASoC: topology: Add definitions for mclk_direction values

has been applied to the asoc tree at 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


>From e590522a06adce8ca2eb47e77d80616cd1542d91 Mon Sep 17 00:00:00 2001
From: Kirill Marinushkin <>
Date: Wed, 4 Apr 2018 06:19:39 +0200
Subject: [PATCH] ASoC: topology: Add definitions for mclk_direction values

Current comment makes not clear the direction of mclk. Previously, similar
description caused a misunderstanding for bclk_master and fsync_master.

This commit solves the potential confusion the same way it is solved for
bclk_master and fsync_master.

Signed-off-by: Kirill Marinushkin <>
Acked-by: Pierre-Louis Bossart <>
Cc: Jaroslav Kysela <>
Cc: Takashi Iwai <>
Cc: Mark Brown <>
Cc: Pan Xiuli <>
Cc: Liam Girdwood <>
Signed-off-by: Mark Brown <>
 include/uapi/sound/asoc.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
index f3c4b46e39d8..b901cdbe532a 100644
--- a/include/uapi/sound/asoc.h
+++ b/include/uapi/sound/asoc.h
@@ -144,6 +144,10 @@
+/* DAI mclk_direction */
+#define SND_SOC_TPLG_MCLK_CO            0 /* for codec, mclk is output */
+#define SND_SOC_TPLG_MCLK_CI            1 /* for codec, mclk is input */
 /* DAI physical PCM data formats.
  * Add new formats to the end of the list.
@@ -334,7 +338,7 @@ struct snd_soc_tplg_hw_config {
 	__u8 invert_fsync;	/* 1 for inverted frame clock, 0 for normal */
 	__u8 bclk_master;	/* SND_SOC_TPLG_BCLK_ value */
 	__u8 fsync_master;	/* SND_SOC_TPLG_FSYNC_ value */
-	__u8 mclk_direction;    /* 0 for input, 1 for output */
+	__u8 mclk_direction;    /* SND_SOC_TPLG_MCLK_ value */
 	__le16 reserved;	/* for 32bit alignment */
 	__le32 mclk_rate;	/* MCLK or SYSCLK freqency in Hz */
 	__le32 bclk_rate;	/* BCLK freqency in Hz */

  reply	other threads:[~2018-04-16 17:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  4:19 [PATCH v4 0/3] ASoC: topology: Improve hw_configs Kirill Marinushkin
2018-04-04  4:19 ` [PATCH v4 1/3] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() Kirill Marinushkin
2018-04-04  4:19 ` [PATCH v4 2/3] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-04-16 16:52   ` Mark Brown
2018-04-16 17:56     ` [PATCH] ASoC: topology: Modify clock gating parameter parsing to switch Kirill Marinushkin
2018-04-16 18:46       ` Applied "ASoC: topology: Modify clock gating parameter parsing to switch" to the asoc tree Mark Brown
2018-04-04  4:19 ` [PATCH v4 3/3] ASoC: topology: Add definitions for mclk_direction values Kirill Marinushkin
2018-04-16 17:15   ` Mark Brown [this message]
2018-04-04 18:57 ` [alsa-devel] [PATCH v4 0/3] ASoC: topology: Improve hw_configs Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1f87iu-0002wh-VJ@debutante \ \ \ \ \ \ \ \ \ \
    --subject='Re: Applied "ASoC: topology: Add definitions for mclk_direction values" to the asoc tree' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).