LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Modi, Geet" <geet.modi@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Nagalla, Hari" <hnagalla@ti.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Sharma, Vikram" <vikram.sharma@ti.com>
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83tc811: modify list of interrupts enabled at initialization
Date: Fri, 10 Sep 2021 00:41:53 +0000	[thread overview]
Message-ID: <E3DBDC45-111F-4744-82A8-95C7D5CCEBE5@ti.com> (raw)
In-Reply-To: <YTpwjWEUmJWo0mwr@lunn.ch>

Hi Andrew,

As mentioned we want to do this in phases: 
a) this patch to disable the Overvoltage driver interrupt
b) After carefully considering other interrupts, plan a  follow-on patch to take care of other interrupts.

Patch comment will be inline with your suggestion

"The over voltage interrupt is enabled, but if it ever occurs, there is no code to make use of it. So removing it. It
    can re-enabled when HWMON support is added "

Regarfds,
Geet


On 9/9/21, 1:37 PM, "Andrew Lunn" <andrew@lunn.ch> wrote:

    > I am planning to have following commit msg;
    > 
    >  
    > 
    > “This feature is not used by our mainstream customers as they have additional

    As i said, this is not your driver, for you customers. It is the Linux
    kernel driver. Please drop all references to your customers. If you
    need to address anybody, it should be the Linux community as a whole,
    or maybe the users of this driver.

    > mechanism to monitor the supply at System level as accuracy requirements are
    > different for each application.  The device is designed with inbuilt monitor
    > with interrupt disabled by default and let user choose if they want to exercise
    > the monitor. However, the driver had this interrupt enabled, the request here
    > is disable it by default in driver however not change in datasheet.  Let user
    > of the driver review the accuracy offered by monitor and if meets the
    > expectation, they can always enable it.”

    I would much more prefer something like...

    The over voltage interrupt is enabled, but if it every occurs, there is
    no code to make use of it. So remove the pointless enabling of it. It
    can re-enabled when HWMON support is added. For the same reason,
    enabling of the interrupts DP83811_RX_ERR_HF_INT_EN,
    DP83811_MS_TRAINING_INT_EN, DP83811_ESD_EVENT_INT_EN,
    DP83811_ENERGY_DET_INT_EN, DP83811_LINK_QUAL_INT_EN,
    DP83811_JABBER_DET_INT_EN, DP83811_POLARITY_INT_EN,
    DP83811_SLEEP_MODE_INT_EN, DP83811_OVERTEMP_INT_EN,
    DP83811_UNDERVOLTAGE_INT_EN is also removed, since there is no code
    which acts on these interrupts.

    And update the patch to fit.

          Andrew


  reply	other threads:[~2021-09-10  1:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 19:09 hnagalla
2021-09-02 23:23 ` Andrew Lunn
2021-09-06 20:51   ` [EXTERNAL] " Modi, Geet
2021-09-07 14:02     ` Andrew Lunn
     [not found]       ` <E61A9519-DBA6-4931-A2A0-78856819C362@ti.com>
2021-09-09 20:37         ` [EXTERNAL] " Andrew Lunn
2021-09-10  0:41           ` Modi, Geet [this message]
2021-09-10  1:30             ` [EXTERNAL] " Andrew Lunn
2021-09-10  1:42               ` [EXTERNAL] " Modi, Geet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E3DBDC45-111F-4744-82A8-95C7D5CCEBE5@ti.com \
    --to=geet.modi@ti.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hnagalla@ti.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vikram.sharma@ti.com \
    --subject='Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83tc811: modify list of interrupts enabled at initialization' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).