LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls
@ 2015-02-17 15:08 Ricardo Ribalda Delgado
  2015-02-23  9:06 ` Hans Verkuil
  0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-02-17 15:08 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Hans Verkuil, Sylwester Nawrocki,
	Sakari Ailus, Antti Palosaari, linux-media, linux-kernel
  Cc: Ricardo Ribalda Delgado

Volatile controls can change their value outside the v4l-ctrl framework.
We should ignore the cached written value of the ctrl when evaluating if
we should run s_ctrl.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
v4: Hans Verkuil:

explicity set has_changed to false. and add comment

 drivers/media/v4l2-core/v4l2-ctrls.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index 45c5b47..f34a689 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -1609,6 +1609,17 @@ static int cluster_changed(struct v4l2_ctrl *master)
 
 		if (ctrl == NULL)
 			continue;
+
+		if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE) {
+			/*
+			 * Set has_changed to false to avoid generating
+			 * the event V4L2_EVENT_CTRL_CH_VALUE
+			 */
+			ctrl->has_changed = false;
+			changed = true;
+			continue;
+		}
+
 		for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)
 			ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,
 				ctrl->p_cur, ctrl->p_new);
-- 
2.1.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-03-16 11:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 15:08 [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls Ricardo Ribalda Delgado
2015-02-23  9:06 ` Hans Verkuil
2015-02-23 23:07   ` Laurent Pinchart
2015-02-24  1:04     ` Ricardo Ribalda Delgado
2015-03-09 16:45     ` Ricardo Ribalda Delgado
2015-03-16 11:05       ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).