LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1
@ 2018-03-05 12:48 Konstantin Khlebnikov
  2018-03-19  6:03 ` Paolo Valente
  0 siblings, 1 reply; 10+ messages in thread
From: Konstantin Khlebnikov @ 2018-03-05 12:48 UTC (permalink / raw)
  To: linux-block, Jens Axboe, Paolo Valente, linux-kernel

Rate should never overflow or become zero because it is used as divider.
This patch accumulates it with saturation.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
 block/bfq-iosched.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index aeca22d91101..a236c8d541b5 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -2546,7 +2546,8 @@ static void bfq_reset_rate_computation(struct bfq_data *bfqd,
 
 static void bfq_update_rate_reset(struct bfq_data *bfqd, struct request *rq)
 {
-	u32 rate, weight, divisor;
+	u32 weight, divisor;
+	u64 rate;
 
 	/*
 	 * For the convergence property to hold (see comments on
@@ -2634,9 +2635,10 @@ static void bfq_update_rate_reset(struct bfq_data *bfqd, struct request *rq)
 	 */
 	bfqd->peak_rate *= divisor-1;
 	bfqd->peak_rate /= divisor;
-	rate /= divisor; /* smoothing constant alpha = 1/divisor */
+	do_div(rate, divisor);	/* smoothing constant alpha = 1/divisor */
 
-	bfqd->peak_rate += rate;
+	/* rate should never overlow or become zero */
+	bfqd->peak_rate = clamp_t(u64, rate + bfqd->peak_rate, 1, U32_MAX);
 	update_thr_responsiveness_params(bfqd);
 
 reset_computation:

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-03-26 14:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05 12:48 [PATCH] block, bfq: keep peak_rate estimation within range 1..2^32-1 Konstantin Khlebnikov
2018-03-19  6:03 ` Paolo Valente
2018-03-19  6:28   ` Konstantin Khlebnikov
2018-03-20  3:00     ` Paolo Valente
2018-03-20  7:41       ` Konstantin Khlebnikov
2018-03-20 23:49         ` Paolo Valente
2018-03-26  8:01           ` Paolo Valente
2018-03-26 10:28             ` Konstantin Khlebnikov
2018-03-26 14:06               ` Paolo Valente
2018-03-26 14:18                 ` Konstantin Khlebnikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).