LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings
       [not found] <20210806013516.26148-1-mark-yw.chen@mediatek.com>
@ 2021-08-06 12:50 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-08-06 12:50 UTC (permalink / raw)
  To: Mark-YW.Chen
  Cc: Johan Hedberg, Tedd Ho-Jeong An, chris.lu, will-cy.lee,
	Sean Wang, BlueZ, linux-mediatek, open list, Michael Sun,
	shawnku, jemele, Archie Pusaka, Miao-chen Chou

Hi Mark,

> Fix fall-through warnings:
> drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
> drivers/bluetooth/btusb.c:4033:3: warning:
> this statement may fall through [-Wimplicit-fallthrough=]
> 4033 |   usb_disable_autosuspend(data->udev);
>      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:4034:2: note: here
> 4034 |  case 0x05ff:  /* Firmware debug logging 1 */
>      |  ^~~~
> 
> Signed-off-by: mark-yw.chen <mark-yw.chen@mediatek.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings
       [not found] <20210805024012.18022-1-mark-yw.chen@mediatek.com>
@ 2021-08-05 13:18 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-08-05 13:18 UTC (permalink / raw)
  To: "Mark-YW Chen (陳揚文)"
  Cc: Johan Hedberg, tedd.an, chris.lu, will-cy.lee, sean.wang,
	linux-bluetooth, linux-mediatek, linux-kernel, michaelfsun,
	shawnku, jemele, apusaka, mcchou

Hi Mark,

> Fix fall-through warnings:
> drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
> drivers/bluetooth/btusb.c:4033:3: warning:
> this statement may fall through [-Wimplicit-fallthrough=]
> 4033 |   usb_disable_autosuspend(data->udev);
>      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:4034:2: note: here
> 4034 |  case 0x05ff:  /* Firmware debug logging 1 */
>      |  ^~~~
> 
> Signed-off-by: mark-yw.chen <mark-yw.chen@mediatek.com>
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index a4cee8327295..89ff9182b7e2 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -4027,7 +4027,9 @@ static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb)
> 		 * suspend and thus disable auto-suspend.
> 		 */
> 		usb_disable_autosuspend(data->udev);
> +		fallthrough;
> 	case 0x05ff:		/* Firmware debug logging 1 */
> +		fallthrough;

this one is not needed.


> 	case 0x05fe:		/* Firmware debug logging 2 */
> 		return hci_recv_diag(hdev, skb);
> 	}

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-06 12:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210806013516.26148-1-mark-yw.chen@mediatek.com>
2021-08-06 12:50 ` [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings Marcel Holtmann
     [not found] <20210805024012.18022-1-mark-yw.chen@mediatek.com>
2021-08-05 13:18 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).