LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Zhang Wei <wei.zhang@freescale.com>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] Add multi mport support.
Date: Thu, 31 Jan 2008 00:20:41 -0600	[thread overview]
Message-ID: <F2D2FCC7-D1ED-4DC6-BE7A-EE2755CCE125@kernel.crashing.org> (raw)
In-Reply-To: <EC566605-6890-4983-8700-3B15C9EFC1C5@kernel.crashing.org>


On Jan 31, 2008, at 12:15 AM, Kumar Gala wrote:

>
> On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote:
>
>>
>>
>>> -----Original Message-----
>>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>>>
>>> On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote:
>>>
>>>> Change lots of static variable to mport private. And add
>>> mport to some
>>>> function declaration.
>>>
>>> Can you explain this patch further.  Its not clear exactly from this
>>> commit message why we are doing this.
>>>
>>> - k
>>
>> Sorry about I have a little hurry about it.
>>
>> The original RapidIO driver suppose there is only one mpc85xx RIO
>> controller
>> in system. So, some data structures are defined as mpc85xx_rio  
>> global,
>> such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I changed them
>> to
>> mport's private members. And you can define multi RIO OF-nodes in dts
>> file
>> for multi RapidIO controller in one processor, such as PCI/PCI-Ex  
>> host
>> controllers
>> in Freescale's silicon. And the mport operation function declaration
>> should be changed
>> to know which RapidIO controller is target.
>
> thanks, this makes a lot of sense and now reviewing the patch will
> make some sense to me :)

when we have multiple ports are the device IDs on the ports intended  
to be unique only to a port or unique across all ports?

- k

  reply	other threads:[~2008-01-31  6:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:30 [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Zhang Wei
2008-01-30 10:30 ` [PATCH 2/6] Add RapidIO option to kernel configuration Zhang Wei
2008-01-30 10:30   ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Zhang Wei
2008-01-30 10:30     ` [PATCH 4/6] Add multi mport support Zhang Wei
2008-01-30 10:30       ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Zhang Wei
2008-01-30 10:30         ` [PATCH 6/6] Change the kernel configurated RapidIO system size to auto-probing Zhang Wei
2008-02-05 16:43           ` Matt Porter
2008-02-05  5:44         ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Stephen Rothwell
2008-02-05 16:06           ` Kumar Gala
2008-02-18  7:24             ` Zhang Wei
2008-01-30 14:27       ` [PATCH 4/6] Add multi mport support Kumar Gala
2008-01-31  5:57         ` Zhang Wei
2008-01-31  6:15           ` Kumar Gala
2008-01-31  6:20             ` Kumar Gala [this message]
2008-01-31  6:30               ` Zhang Wei
2008-01-31 18:35                 ` Phil Terry
2008-02-01  4:06                   ` Zhang Wei
2008-02-05 16:29                 ` Matt Porter
2008-02-18  7:33                   ` Zhang Wei
2008-02-05 16:23           ` Matt Porter
2008-01-30 14:20     ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Kumar Gala
2008-01-31  3:36       ` Zhang Wei
2008-01-30 14:43 ` [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Kumar Gala
2008-01-31  6:04   ` Zhang Wei
2008-01-31  6:15     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F2D2FCC7-D1ED-4DC6-BE7A-EE2755CCE125@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=wei.zhang@freescale.com \
    --subject='Re: [PATCH 4/6] Add multi mport support.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).