LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dexuan Cui <decui@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "'olaf@aepfle.de'" <olaf@aepfle.de>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Jork Loeser <Jork.Loeser@microsoft.com>,
	"'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
	"'jasowang@redhat.com'" <jasowang@redhat.com>,
	"'driverdev-devel@linuxdriverproject.org'"
	<driverdev-devel@linuxdriverproject.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
	"'apw@canonical.com'" <apw@canonical.com>,
	"'marcelo.cerri@canonical.com'" <marcelo.cerri@canonical.com>,
	"'vkuznets@redhat.com'" <vkuznets@redhat.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0
Date: Tue, 8 May 2018 23:06:02 +0000	[thread overview]
Message-ID: <KL1P15301MB00064D52564FA764B6B00CE9BF9A0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20180508154525.37b6ddee@xeon-e3>

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, May 8, 2018 15:45
> On Tue, 8 May 2018 22:26:21 +0000
> Dexuan Cui <decui@microsoft.com> wrote:
> 
> > @@ -63,6 +63,9 @@ static __u32 vmbus_get_next_version(__u32
> current_version)
> >  	case (VERSION_WIN10):
> >  		return VERSION_WIN8_1;
> >
> > +	case (VERSION_WIN10_V5):
> > +		return VERSION_WIN10;
> > +
> >  	case (VERSION_WS2008):
> 
> In a future patch, we should get rid of the use of parenthesis on this switch
> statement.  Lots of other cleanup of this code is possible as well.

I agree.
We can make another patch to clean up this function. Maybe we should
replace the function with an array of versions.

Thanks,
-- Dexuan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2018-05-08 23:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 22:26 Dexuan Cui
2018-05-08 22:45 ` Stephen Hemminger
2018-05-08 23:06   ` Dexuan Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=KL1P15301MB00064D52564FA764B6B00CE9BF9A0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM \
    --to=decui@microsoft.com \
    --cc=Jork.Loeser@microsoft.com \
    --cc=Michael.H.Kelley@microsoft.com \
    --cc=apw@canonical.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=olaf@aepfle.de \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    --subject='RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).