LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'
@ 2019-05-25 12:20 YueHaibing
  2019-05-29 20:35 ` Paul Burton
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-05-25 12:20 UTC (permalink / raw)
  To: ralf, paul.burton, jhogan; +Cc: linux-kernel, linux-mips, YueHaibing

Fixes gcc '-Wunused-but-set-variable' warning:

arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]

It's never used since introduction in
commit 40e084a506eb ("MIPS: Add uprobes support.")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/mips/kernel/uprobes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/mips/kernel/uprobes.c b/arch/mips/kernel/uprobes.c
index 4aaff3b3175c..6dbe4eab0a0e 100644
--- a/arch/mips/kernel/uprobes.c
+++ b/arch/mips/kernel/uprobes.c
@@ -112,9 +112,6 @@ int arch_uprobe_pre_xol(struct arch_uprobe *aup, struct pt_regs *regs)
 	 */
 	aup->resume_epc = regs->cp0_epc + 4;
 	if (insn_has_delay_slot((union mips_instruction) aup->insn[0])) {
-		unsigned long epc;
-
-		epc = regs->cp0_epc;
 		__compute_return_epc_for_insn(regs,
 			(union mips_instruction) aup->insn[0]);
 		aup->resume_epc = regs->cp0_epc;
-- 
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'
  2019-05-25 12:20 [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc' YueHaibing
@ 2019-05-29 20:35 ` Paul Burton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-05-29 20:35 UTC (permalink / raw)
  To: YueHaibing
  Cc: ralf, Paul Burton, jhogan, linux-kernel, linux-mips, YueHaibing,
	linux-mips

Hello,

YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> arch/mips/kernel/uprobes.c: In function 'arch_uprobe_pre_xol':
> arch/mips/kernel/uprobes.c:115:17: warning: variable 'epc' set but not used [-Wunused-but-set-variable]
> 
> It's never used since introduction in
> commit 40e084a506eb ("MIPS: Add uprobes support.")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-29 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 12:20 [PATCH -next] MIPS: uprobes: remove set but not used variable 'epc' YueHaibing
2019-05-29 20:35 ` Paul Burton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).