LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Stevens <dlstevens@us.ibm.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{,6} device initialization order."
Date: Sun, 14 Jan 2007 19:47:49 -0800	[thread overview]
Message-ID: <OF0ECEC103.470302BB-ON88257264.00142A49-88257264.0014DC27@us.ibm.com> (raw)
In-Reply-To: <45AAF3AC.3070600@gentoo.org>

I expect this is the failure to join the all-nodes multicast group,
in which case the fix has already been posted to netdev. I
believe the router advertisements are sent to that, and if the
join failed, it wouldn't receive any of them.

I think it's better to add the fix than withdraw this patch, since
the original bug is a crash.

Details:
The IPv6 code passes the "dev" entry to the multicast group
incrementer and uses it to dereference to get the in6_dev.
IPv4, by contrast, passes the in_dev directly to its equivalent
functions.

IPv6 joins the required "all-nodes" multicast group in the
multicast device initialization function, which due to the fix
won't have a dev entry at that time. The patch posted by
Yoshifuji Hideaki moves the all-nodes join until after the
ip6_ptr is added to the dev.

                                        +-DLS


  reply	other threads:[~2007-01-15  3:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15  3:23 Daniel Drake
2007-01-15  3:47 ` David Stevens [this message]
2007-01-15  5:30   ` David Miller
2007-01-15  7:25     ` [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} " Greg KH
2007-01-16  2:01       ` Gabriel C
2007-01-16  2:06         ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-16  2:56           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF0ECEC103.470302BB-ON88257264.00142A49-88257264.0014DC27@us.ibm.com \
    --to=dlstevens@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=dsd@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --subject='Re: 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{,6} device initialization order."' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).