LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joachim Fenkes <FENKES@de.ibm.com>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>,
	johnrose@us.ibm.com, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, paulus@samba.org, pmac@au1.ibm.com
Subject: Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()
Date: Sat, 17 Feb 2007 10:53:15 -0500	[thread overview]
Message-ID: <OFA3D529A5.FA8E67C7-ON85257285.00570531-85257285.0057458C@de.ibm.com> (raw)
In-Reply-To: <45D6CC81.1040004@246tNt.com>

Sylvain Munaut <tnt@246tNt.com> wrote on 17.02.2007 04:36:01:

> Doesn't that oops when called with the fake parent device ?

I should stop posting patches after 12 hours of work ,)

> Or, an even better approach is to add this
> 
> +   if (!ebus_dev->ofdev.node)
> +      return -ENODEV;
> 
> inside the code of of_device_uevent itself.

Nice! Patch will follow.

Thanks again,
  Joachim

---
Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer 
extraordinaire
IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Development 
2)
Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany
eMail: fenkes@de.ibm.com  --  Phone: +49 7031 16 1239 

Vorsitzender des Aufsichtsrats: Johann Weihen  --  Geschäftsführung: 
Herbert Kircher
Sitz der Gesellschaft: Böblingen  --  Registergericht: Amtsgericht 
Stuttgart, HRB 243294



      reply	other threads:[~2007-02-17 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17  2:56 Hoang-Nam Nguyen
2007-02-17  9:36 ` Sylvain Munaut
2007-02-17 15:53   ` Joachim Fenkes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OFA3D529A5.FA8E67C7-ON85257285.00570531-85257285.0057458C@de.ibm.com \
    --to=fenkes@de.ibm.com \
    --cc=hnguyen@linux.vnet.ibm.com \
    --cc=johnrose@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=pmac@au1.ibm.com \
    --cc=tnt@246tNt.com \
    --subject='Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).