LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Colin King <colin.king@canonical.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][next] iio: adc: Fix -EBUSY timeout error return
Date: Wed, 18 Aug 2021 15:50:32 +0000	[thread overview]
Message-ID: <OSZPR01MB7019DD199CB1B9A4521A3C28AAFF9@OSZPR01MB7019.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210817172111.495897-1-colin.king@canonical.com>

Hi Colin,

Thank you for the patch.

> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: 17 August 2021 18:21
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Jonathan Cameron
> <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Biju Das <biju.das.jz@bp.renesas.com>;
> linux-iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] iio: adc: Fix -EBUSY timeout error return
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently when a timeout occurs in rzg2l_adc_hw_init the error -EBUSY is assigned to ret but the error
> code is used as the function is hard-coded to return 0.  The variable ret is 0 before entering the
> while-loop hence the fix is just to return ret at the end of the function to return the success 0 or -
> EBUSY return code.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: d484c21bacfa ("iio: adc: Add driver for Renesas RZ/G2L A/D converter")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iio/adc/rzg2l_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
iio: adc: rzg2l_adc: Fix -EBUSY timeout error return

with the subject changed to above: Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> 9996d5eef289..868b183e75ea 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -401,7 +401,7 @@ static int rzg2l_adc_hw_init(struct rzg2l_adc *adc)
>  exit_hw_init:
>  	clk_disable_unprepare(adc->pclk);
> 
> -	return 0;
> +	return ret;
>  }
> 
>  static void rzg2l_adc_pm_runtime_disable(void *data)
> --
> 2.32.0


  reply	other threads:[~2021-08-18 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 17:21 Colin King
2021-08-18 15:50 ` Prabhakar Mahadev Lad [this message]
2021-08-19 17:20   ` Andy Shevchenko
2021-08-19 17:39     ` Lad, Prabhakar
2021-08-29 17:01       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSZPR01MB7019DD199CB1B9A4521A3C28AAFF9@OSZPR01MB7019.jpnprd01.prod.outlook.com \
    --to=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=colin.king@canonical.com \
    --cc=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --subject='RE: [PATCH][next] iio: adc: Fix -EBUSY timeout error return' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).