LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Song, Yoong Siang" <yoong.siang.song@intel.com>
To: Russell King <linux@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>
Cc: "Marek Behún" <kabel@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event
Date: Mon, 16 Aug 2021 03:52:06 +0000	[thread overview]
Message-ID: <PH0PR11MB4950652B4D07C189508767F1D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210814194916.GB22278@shell.armlinux.org.uk>

> > Agreed. If the interrupt register is being used, i think we need this
> > patchset to add proper interrupt support. Can you recommend a board
> > they can buy off the shelf with the interrupt wired up? Or maybe Intel
> > can find a hardware engineer to add a patch wire to link the interrupt
> > output to a SoC pin that can do interrupts.
> 
> The only board I'm aware of with the 88x3310 interrupt wired is the
> Macchiatobin double-shot. :)
> 
> I forget why I didn't implement interrupt support though - I probably need to
> revisit that. Sure enough, looking at the code I was tinkering with, adding
> interrupt support would certainly conflict with this patch.

Hi Russell,

For EHL board, both WoL interrupt and link change interrupt are the same pin.
Based on your knowledge, is this common across other platforms?
Can we take set wol function as one of the ways to control the interrupts?

Regards,
Siang

> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2021-08-16  3:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  8:45 [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Song Yoong Siang
2021-08-14 17:19 ` Marek Behún
2021-08-14 17:26 ` Russell King (Oracle)
2021-08-14 18:04   ` Andrew Lunn
2021-08-14 19:49     ` Russell King (Oracle)
2021-08-16  3:52       ` Song, Yoong Siang [this message]
2021-08-16  4:15         ` Andrew Lunn
2021-08-16  5:40           ` Song, Yoong Siang
2021-08-16  7:14             ` Russell King (Oracle)
2021-08-16  8:03               ` Song, Yoong Siang
2021-08-16  8:18                 ` Russell King (Oracle)
2021-08-16  8:56                   ` Song, Yoong Siang
2021-08-16  9:54                     ` Marek Behún
2021-08-16 15:02                       ` Song, Yoong Siang
2021-08-16 15:27                         ` Andrew Lunn
2021-08-20  1:22                           ` Song, Yoong Siang
2021-08-16  3:19     ` Song, Yoong Siang
2021-08-16  4:10       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB4950652B4D07C189508767F1D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com \
    --to=yoong.siang.song@intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).