LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Song, Yoong Siang" <email@example.com> To: Andrew Lunn <firstname.lastname@example.org> Cc: "Marek Behún" <email@example.com>, "Russell King" <firstname.lastname@example.org>, "Heiner Kallweit" <email@example.com>, "David S . Miller" <firstname.lastname@example.org>, "Jakub Kicinski" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Date: Fri, 20 Aug 2021 01:22:50 +0000 [thread overview] Message-ID: <PH0PR11MB4950AF75A507FDB0885174DAD8C19@PH0PR11MB4950.namprd11.prod.outlook.com> (raw) In-Reply-To: <YRqDz9QZwqjadNdL@lunn.ch> > > > > Yes, you are right. I missed the effect of get_wol. > > > > Is it needed in future to implement link change interrupt in phy > > > > driver? Cause I dint see much phy driver implement link change > > > > interrupt. > > > > > > If there is a board that has interrupt pin wired correctly from the > > > PHY and the interrupt controller is safe to use (i.e. it is not a > > > PCA953x which cannot handle interrupt storms correctly), then I > > > think the PHY driver should use the interrupt, instead of polling. > > > > > > Marek > > > > Any suggestion to avoid the conflict of "WoL on link change" mentioned by > Russell? > > Is it make sense to create a new member called wolopts under struct > > phy_device to track the WoL status and return the correct status in get_wol > callback? > > I really think you need to look at your PMC and see if you can make it an > interrupt controller. You only need level interrupts, not edge. So the > microcontroller in the PMC could just poll the GPIO. There appears to be a > simple IPC between the host and PMC, so just extend it with a couple of > registers, interrupt state, interrupt mask, and make use of the existing > interrupt between the host and PMC. > > Andrew Thanks for your suggestion. Currently, PMC is designed for platform-wide power management and not meant to control any device specific registers. Seem like it is not possible to make PMC an interrupt controller, but I will continue to discuss more with my team. Regards Siang
next prev parent reply other threads:[~2021-08-20 1:25 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-13 8:45 [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Song Yoong Siang 2021-08-14 17:19 ` Marek Behún 2021-08-14 17:26 ` Russell King (Oracle) 2021-08-14 18:04 ` Andrew Lunn 2021-08-14 19:49 ` Russell King (Oracle) 2021-08-16 3:52 ` Song, Yoong Siang 2021-08-16 4:15 ` Andrew Lunn 2021-08-16 5:40 ` Song, Yoong Siang 2021-08-16 7:14 ` Russell King (Oracle) 2021-08-16 8:03 ` Song, Yoong Siang 2021-08-16 8:18 ` Russell King (Oracle) 2021-08-16 8:56 ` Song, Yoong Siang 2021-08-16 9:54 ` Marek Behún 2021-08-16 15:02 ` Song, Yoong Siang 2021-08-16 15:27 ` Andrew Lunn 2021-08-20 1:22 ` Song, Yoong Siang [this message] 2021-08-16 3:19 ` Song, Yoong Siang 2021-08-16 4:10 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR11MB4950AF75A507FDB0885174DAD8C19@PH0PR11MB4950.namprd11.prod.outlook.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).