LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Song, Yoong Siang" <firstname.lastname@example.org> To: Andrew Lunn <email@example.com>, "Russell King (Oracle)" <firstname.lastname@example.org> Cc: "Marek Behún" <email@example.com>, "Heiner Kallweit" <firstname.lastname@example.org>, "David S . Miller" <email@example.com>, "Jakub Kicinski" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org> Subject: RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Date: Mon, 16 Aug 2021 03:19:34 +0000 [thread overview] Message-ID: <PH0PR11MB4950EAF1FC749EAAE3FDFCB7D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com> (raw) In-Reply-To: <YRgFxzIB3v8wS4tF@lunn.ch> > > How does this work if the driver has no interrupt support? What is the > > hardware setup this has been tested with? > > Hi Russell > > We already know from previous patches that the Intel hardware is broken, > and does not actually deliver the interrupt which caused the wake up. So i > assume this just continues on with the same broken hardware, but they have > a different PHY connected. Hi Russell & Andrew, This is tested on Intel Elkhart Lake (EHL) board. We are using polling mode. Both WoL interrupt and link change interrupt are the same pin which is routed to PMC. PMC will wake up the system when there is WoL event. Regards Siang > > > What if we later want to add interrupt support to this driver to > > support detecting changes in link state - isn't using this bit in the > > interrupt enable register going to confict with that? > > Agreed. If the interrupt register is being used, i think we need this patchset to > add proper interrupt support. Can you recommend a board they can buy off > the shelf with the interrupt wired up? Or maybe Intel can find a hardware > engineer to add a patch wire to link the interrupt output to a SoC pin that can > do interrupts. > > Andrew
next prev parent reply other threads:[~2021-08-16 3:19 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-13 8:45 [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Song Yoong Siang 2021-08-14 17:19 ` Marek Behún 2021-08-14 17:26 ` Russell King (Oracle) 2021-08-14 18:04 ` Andrew Lunn 2021-08-14 19:49 ` Russell King (Oracle) 2021-08-16 3:52 ` Song, Yoong Siang 2021-08-16 4:15 ` Andrew Lunn 2021-08-16 5:40 ` Song, Yoong Siang 2021-08-16 7:14 ` Russell King (Oracle) 2021-08-16 8:03 ` Song, Yoong Siang 2021-08-16 8:18 ` Russell King (Oracle) 2021-08-16 8:56 ` Song, Yoong Siang 2021-08-16 9:54 ` Marek Behún 2021-08-16 15:02 ` Song, Yoong Siang 2021-08-16 15:27 ` Andrew Lunn 2021-08-20 1:22 ` Song, Yoong Siang 2021-08-16 3:19 ` Song, Yoong Siang [this message] 2021-08-16 4:10 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR11MB4950EAF1FC749EAAE3FDFCB7D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).