LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] spurious swap_list_unlock
Date: Mon, 8 Oct 2001 09:42:14 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0110080932380.1379-100000@localhost.localdomain> (raw)
In-Reply-To: <20011008002426.I726@athlon.random>

On Mon, 8 Oct 2001, Andrea Arcangeli wrote:
> On Sun, Oct 07, 2001 at 01:35:58AM +0200, Andrea Arcangeli wrote:
> > On Thu, Oct 04, 2001 at 10:57:09PM +0200, Andrea Arcangeli wrote:
> > > 2) Hugh's locking cleanups
> > 
> > checked now (of course it's just in pre4), very nice.
> 
> btw, while playing with the code I now noticed a swap_list_unlock
> leftover in vmscan.c.

Eek, that's not at all nice!  Many thanks for spotting it,
and for your review, Andrea.  I'll check it all over again.
For others' sake, patch for 2.4.11-pre5 or 2.4.11-pre4 below.

Hugh

--- 2.4.11-pre5/mm/vmscan.c	Sun Oct  7 20:54:29 2001
+++ linux/mm/vmscan.c	Mon Oct  8 09:32:13 2001
@@ -139,7 +139,6 @@
 	}
 
 	/* No swap space left */
-	swap_list_unlock();
 	set_pte(page_table, pte);
 	UnlockPage(page);
 	return 0;


      reply	other threads:[~2001-10-08  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-04 20:57 2.4.11pre3aa1 Andrea Arcangeli
2001-10-06 23:35 ` 2.4.11pre3aa1 Andrea Arcangeli
2001-10-07 22:24   ` 2.4.11pre3aa1 Andrea Arcangeli
2001-10-08  8:42     ` Hugh Dickins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0110080932380.1379-100000@localhost.localdomain \
    --to=hugh@veritas.com \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --subject='Re: [PATCH] spurious swap_list_unlock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).