LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Possible change to ./scripts/split-include.c
@ 2001-10-08 16:05 Bob Miller
  2001-10-08 18:48 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Bob Miller @ 2001-10-08 16:05 UTC (permalink / raw)
  To: torvalds, kaos; +Cc: linux-kernel, jamal.hadi

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

We are using CVS to keep track of the Linux kernels.  I am trying to 
solve a problem where split-include clobbers our CVS directory under 
./include/config.  I made a small change to split-include.c that only 
finds files that are header files(.h).   However, I am unsure of the 
history of split-include, and am concerned about possible side effects.

If this change is reasonable, could you consider merging it into future 
kernels.  Attached is a diff -u for the change to split-include.c


Thanks,
Bob Miller
bobm@znyx.com





[-- Attachment #2: afile-1 --]
[-- Type: text/plain, Size: 362 bytes --]

--- split-include.c,orig	Fri Oct  5 08:34:34 2001
+++ split-include.c	Fri Oct  5 08:42:53 2001
@@ -188,7 +188,7 @@
      * So by having an initial \n, strstr will find exact matches.
      */
 
-    fp_find = popen("find * -type f -print", "r");
+    fp_find = popen("find * -type f -name \"*.h\" -print", "r");
     if (fp_find == 0)
 	ERROR_EXIT( "find" );
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Possible change to ./scripts/split-include.c
  2001-10-08 16:05 Possible change to ./scripts/split-include.c Bob Miller
@ 2001-10-08 18:48 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2001-10-08 18:48 UTC (permalink / raw)
  To: Bob Miller; +Cc: kaos, linux-kernel, jamal.hadi


On Mon, 8 Oct 2001, Bob Miller wrote:
>
> If this change is reasonable, could you consider merging it into future
> kernels.  Attached is a diff -u for the change to split-include.c

Looks reasonable to me - the only non-*.h files I find in the include
directory seems to be automatically generated with no config information.

		Linus


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-10-08 18:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-08 16:05 Possible change to ./scripts/split-include.c Bob Miller
2001-10-08 18:48 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).