Re: USB OOPS 2.6.25-rc2-git1

[Alan Stern <stern@rowland.harvard.edu>]

On Tue, 19 Feb 2008, David Brownell wrote:

> Please try that diagnostic patch I sent ... with CONFIG_USB_DEBUG.
> 
> Near as I can tell this is caused by some hardware oddity that needs
> to be worked around.  We seem to be at stage where we've fixed some
> problems, nudging code paths around so another one shows up, and have
> incidentally had a new silicion-specific hardware erratum reported
> in this area.  So more info is needed...
> 
> A quick anti-oops patch is appended, it should work OK on top of that
> diagnostic patch, but won't necessarily resolve the underlying problem.
> 
> - Dave
> 
> 
> --- g26.orig/drivers/usb/host/ehci-q.c	2008-02-19 16:15:04.000000000 -0800
> +++ g26/drivers/usb/host/ehci-q.c	2008-02-19 16:15:59.000000000 -0800
> @@ -993,6 +993,11 @@ static void end_unlink_async (struct ehc
>  
>  	iaa_watchdog_done(ehci);
>  
> +	if (!qh) {
> +		WARN_ON(1);
> +		return;
> +	}
> +

It will be interesting to see the stack dump.  As far as I can tell,
there are two pathways which could lead qh being NULL.  One is the IAA
hardware peculiarity (setting the status bit very late, after the
watchdog timer has already expired), and the other is in unlink_async()  
if the controller isn't running.  That second one may be just a simple
bug -- I doubt it would show up unless the controller got a fatal 
error and stopped.

Alan Stern