LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Greg KH <greg@kroah.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Len Brown <lenb@kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()
Date: Wed, 20 Feb 2008 11:13:39 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.0802201112010.4828-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <200802200201.42543.rjw@sisk.pl>

On Wed, 20 Feb 2008, Rafael J. Wysocki wrote:

> Hi Greg,
> 
> Please consider taking the following fix for 2.6.25.

Don't just consider it!  :-)  It's a real bug fix.

> Thanks,
> Rafael
> 
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Remove an unnecessary unlocking of dpm_list_mtx in the error path
> in drivers/base/power/main.c:dpm_suspend() .
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  drivers/base/power/main.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-2.6/drivers/base/power/main.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/power/main.c
> +++ linux-2.6/drivers/base/power/main.c
> @@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t stat
>  			mutex_lock(&dpm_list_mtx);
>  			if (list_empty(&dev->power.entry))
>  				list_add(&dev->power.entry, &dpm_locked);
> -			mutex_unlock(&dpm_list_mtx);
>  			break;
>  		}
>  		mutex_lock(&dpm_list_mtx);

Acked-by: Alan Stern <stern@rowland.harvard.edu>


  reply	other threads:[~2008-02-20 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20  1:01 Rafael J. Wysocki
2008-02-20 16:13 ` Alan Stern [this message]
2008-02-20 21:57 ` patch pm-remove-unbalanced-mutex_unlock-from-dpm_resume.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.0802201112010.4828-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=greg@kroah.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --subject='Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).