Re: [RFC][PATCH] PM: Make PM core handle device registrations concurrent with suspend/hibernation

[Alan Stern <stern@rowland.harvard.edu>]

On Thu, 6 Mar 2008, Rafael J. Wysocki wrote:

> > > Revised patch below.
> > 
> > It looks good.  Let's hope it doesn't mess up ACPI too badly...  :-)
> > 
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> 
> Thanks!

I thought of one more thing you might want to add: device_pm_add() 
doesn't handle the case where dev->parent is NULL.  You could put in 
that static "all_devices_sleeping" flag, which gets set at the end of 
dpm_suspend() and cleared at the start of dpm_resume().

> Okay, I also have the appended patch on top of this one. :-)
> 
> Rafael
> 
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Include dpm_sysfs_add() into device_pm_add(), in analogy with
> device_pm_remove(), and modify device_add() to call the latter after
> bus_add_device(), to avoid situations in which the PM core may
> attempt to suspend a device the registration of which has not been
> successful.

Clean and simple.  Ack.

Alan Stern