LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: "Jörg Otte" <jrg.otte@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"USB list" <linux-usb@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>
Subject: Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD
Date: Tue, 10 Mar 2015 13:29:55 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1503101322300.1461-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <54FF2403.5030601@linux.intel.com>

On Tue, 10 Mar 2015, Mathias Nyman wrote:

> Yes, thank you
> 
> Seems that It wasn't mature enough, I'll revert it.
> 
> From your logs I can see what went wrong, 
> 
> If you still have some time, could you try out a patch (attached) and see if it solves the
> issue for you. (on top of clean 4.0-rc3). I can't reproduce it with my own USB DVB-T device

Mathias:

Your patch description says this:

> The endpoint might already processesed some TRBs on the endpiont ring
> before we soft reset the endpoint.
> Make sure we set the dequeue pointer to where we were befere soft reset

However, if a driver tries to issue an endpoint reset while there are
still some URBs queued, it is a bug.  Host controller drivers shouldn't
have to worry about this -- xhci_endpoint_reset() should simply return 
an error if the endpoint ring isn't empty.

I suppose we should check for this in the USB core.  I'll write a patch
and CC: you.

Alan Stern


  reply	other threads:[~2015-03-10 17:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  9:40 Jörg Otte
2015-03-10 13:06 ` Mathias Nyman
2015-03-10 14:03   ` Jörg Otte
2015-03-10 15:36     ` Jörg Otte
2015-03-10 17:04       ` Mathias Nyman
2015-03-10 17:29         ` Alan Stern [this message]
2015-03-10 18:21           ` Mathias Nyman
2015-03-10 18:49             ` Alan Stern
2015-03-11  7:04               ` Lu, Baolu
2015-03-11 14:03                 ` Alan Stern
2015-03-11 15:48                   ` Mathias Nyman
2015-03-11  9:00               ` Mathias Nyman
2015-03-11 11:01         ` Jörg Otte
2015-03-11 16:16           ` Jörg Otte
2015-03-12  8:32             ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1503101322300.1461-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jrg.otte@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mchehab@osg.samsung.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).