From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbCJR37 (ORCPT ); Tue, 10 Mar 2015 13:29:59 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:33946 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753974AbbCJR34 (ORCPT ); Tue, 10 Mar 2015 13:29:56 -0400 Date: Tue, 10 Mar 2015 13:29:55 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Mathias Nyman cc: =?UTF-8?B?SsO2cmcgT3R0ZQ==?= , Linux Kernel Mailing List , Greg Kroah-Hartman , USB list , Linus Torvalds , Mauro Carvalho Chehab Subject: Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD In-Reply-To: <54FF2403.5030601@linux.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Mar 2015, Mathias Nyman wrote: > Yes, thank you > > Seems that It wasn't mature enough, I'll revert it. > > From your logs I can see what went wrong, > > If you still have some time, could you try out a patch (attached) and see if it solves the > issue for you. (on top of clean 4.0-rc3). I can't reproduce it with my own USB DVB-T device Mathias: Your patch description says this: > The endpoint might already processesed some TRBs on the endpiont ring > before we soft reset the endpoint. > Make sure we set the dequeue pointer to where we were befere soft reset However, if a driver tries to issue an endpoint reset while there are still some URBs queued, it is a bug. Host controller drivers shouldn't have to worry about this -- xhci_endpoint_reset() should simply return an error if the endpoint ring isn't empty. I suppose we should check for this in the USB core. I'll write a patch and CC: you. Alan Stern