LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Al Niessner <Al.Niessner@jpl.nasa.gov>
Cc: linux-kernel@vger.kernel.org
Subject: Re: atomic_t and atomic_inc
Date: Thu, 22 Apr 2004 16:50:20 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.53.0404221641120.940@chaos> (raw)
In-Reply-To: <1082660320.28900.193.camel@morte.jpl.nasa.gov>

On Thu, 22 Apr 2004, Al Niessner wrote:

>
> First, I am not subscribed to this list so please reply to me directly
> if you wish a timely response to any questions. In any case, I will lurk
> in the archives for responses.
>
> I am using atomic_t to count interrupts from some piece of hardware.
> These interrupts come at a fairly high rate -- 10 KHz and higher. The
> problem is, will I get increment problem at the limit of atomic_t or
> will it wrap around without error? I read the docs (man pages, on-line
> api docs, this list and other stuff) and none of them talk about the
> behavior of atomic_t at the boundaries. Furthermore, am I guaranteed of
> any boundary behavior across platforms?
>
> Thank you in advance for any and all help.

Type atomic_t is an integer that can be accessed in memory
with an uninterruptible instruction. This limits the atomic_t
type in 32-bit machines to 32-bits, in 64-bit machines to 64-bits,
etc. It has nothing to do with wrap-around. If you increment
0xffffffff it becomes 0 even it it's an atomic type.

In an ISR, the code won't be interrupted until you enable interrupts,
which you shouldn't do anyway. This means that even non-atomic types
are safe, even in SMP machines if the increment is after a spin-lock.

So, you can use 'long long' types for interrupt counters and no
information will be lost until you wrap 0xffffffffffffffff, which
will take quite some time. The problem remains, however, in
reading this value. You need to either read it under a spinlock
or read several times until you get the same value twice in a row.

Spin-locks are easier.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.26 on an i686 machine (5557.45 BogoMips).
            Note 96.31% of all statistics are fiction.



  reply	other threads:[~2004-04-22 20:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-22 18:58 Al Niessner
2004-04-22 20:50 ` Richard B. Johnson [this message]
2004-05-15 22:54   ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0404221641120.940@chaos \
    --to=root@chaos.analogic.com \
    --cc=Al.Niessner@jpl.nasa.gov \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: atomic_t and atomic_inc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).