LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
@ 2006-12-05 0:07 art
2006-12-05 1:29 ` Horst H. von Brand
2006-12-05 5:08 ` [PATCH] " Frank Sorenson
0 siblings, 2 replies; 6+ messages in thread
From: art @ 2006-12-05 0:07 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
to: linux-kernel@vger.kernel.org
cc: torvalds@osdl.org
2006/12/04/18:00 CST
Building modules, stage 2.
Kernel: arch/x86_64/boot/bzImage is ready (#2)
MODPOST 1256 modules
WARNING: "current_is_keventd" [drivers/net/phy/libphy.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
xboom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
2006-12-05 0:07 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined art
@ 2006-12-05 1:29 ` Horst H. von Brand
2006-12-05 3:37 ` Linus Torvalds
2006-12-05 5:08 ` [PATCH] " Frank Sorenson
1 sibling, 1 reply; 6+ messages in thread
From: Horst H. von Brand @ 2006-12-05 1:29 UTC (permalink / raw)
To: art; +Cc: linux-kernel, torvalds
art@usfltd.com wrote:
> 2006/12/04/18:00 CST
>
> Building modules, stage 2.
> Kernel: arch/x86_64/boot/bzImage is ready (#2)
> MODPOST 1256 modules
> WARNING: "current_is_keventd" [drivers/net/phy/libphy.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
Also i686, sparc64. At drivers/net/phy/phy.c:590 is the lone reference to
current_is_keventd in that directory. Still present as of ff51a9...
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria +56 32 2654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
2006-12-05 1:29 ` Horst H. von Brand
@ 2006-12-05 3:37 ` Linus Torvalds
2006-12-05 18:31 ` Maciej W. Rozycki
0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2006-12-05 3:37 UTC (permalink / raw)
To: Horst H. von Brand
Cc: art, Linux Kernel Mailing List, Andrew Morton, Ben Collins,
Maciej W. Rozycki, Jeff Garzik
On Mon, 4 Dec 2006, Horst H. von Brand wrote:
> art@usfltd.com wrote:
> > 2006/12/04/18:00 CST
> >
> > Building modules, stage 2.
> > Kernel: arch/x86_64/boot/bzImage is ready (#2)
> > MODPOST 1256 modules
> > WARNING: "current_is_keventd" [drivers/net/phy/libphy.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
>
> Also i686, sparc64. At drivers/net/phy/phy.c:590 is the lone reference to
> current_is_keventd in that directory. Still present as of ff51a9...
Yeah, I'm waiting for this whole mess to be either explained or reverted.
There are apparently bigegr issues with it than just the butt-ugly
"current_is_keventd()" crud.
Linus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
2006-12-05 3:37 ` Linus Torvalds
@ 2006-12-05 18:31 ` Maciej W. Rozycki
2006-12-05 20:09 ` Jan Engelhardt
0 siblings, 1 reply; 6+ messages in thread
From: Maciej W. Rozycki @ 2006-12-05 18:31 UTC (permalink / raw)
To: Linus Torvalds
Cc: Horst H. von Brand, art, Linux Kernel Mailing List,
Andrew Morton, Ben Collins, Jeff Garzik
On Mon, 4 Dec 2006, Linus Torvalds wrote:
> > Also i686, sparc64. At drivers/net/phy/phy.c:590 is the lone reference to
> > current_is_keventd in that directory. Still present as of ff51a9...
>
> Yeah, I'm waiting for this whole mess to be either explained or reverted.
> There are apparently bigegr issues with it than just the butt-ugly
> "current_is_keventd()" crud.
I am very surprised indeed "the mess" has been applied at all in the
first place. The conclusion of the discussion a while ago was to sort out
the issue within libphy. The change should be reverted.
Maciej
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
2006-12-05 18:31 ` Maciej W. Rozycki
@ 2006-12-05 20:09 ` Jan Engelhardt
0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2006-12-05 20:09 UTC (permalink / raw)
To: Maciej W. Rozycki
Cc: Linus Torvalds, Horst H. von Brand, art,
Linux Kernel Mailing List, Andrew Morton, Ben Collins,
Jeff Garzik
>> > Also i686, sparc64. At drivers/net/phy/phy.c:590 is the lone reference to
>> > current_is_keventd in that directory. Still present as of ff51a9...
>>
>> Yeah, I'm waiting for this whole mess to be either explained or reverted.
>> There are apparently bigegr issues with it than just the butt-ugly
>> "current_is_keventd()" crud.
>
> I am very surprised indeed "the mess" has been applied at all in the
>first place. The conclusion of the discussion a while ago was to sort out
>the issue within libphy. The change should be reverted.
I am more surprised about that "the mess" has not been discovered so
far. Does no one go test compile an allyesconfig/allmodconfig before
actually releasing a kernel to the ftp?
-`J'
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Re: 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined
2006-12-05 0:07 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined art
2006-12-05 1:29 ` Horst H. von Brand
@ 2006-12-05 5:08 ` Frank Sorenson
1 sibling, 0 replies; 6+ messages in thread
From: Frank Sorenson @ 2006-12-05 5:08 UTC (permalink / raw)
To: art; +Cc: linux-kernel, torvalds
art@usfltd.com wrote:
> to: linux-kernel@vger.kernel.org
> cc: torvalds@osdl.org
>
> 2006/12/04/18:00 CST
>
> Building modules, stage 2.
> Kernel: arch/x86_64/boot/bzImage is ready (#2)
> MODPOST 1256 modules
> WARNING: "current_is_keventd" [drivers/net/phy/libphy.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> xboom
Here's a patch with the easy fix, but I'm not certain it's a permanent fix.
Frank
This patch fixes a compile error when CONFIG_PHYLIB is a module.
Signed-off-by: Frank Sorenson <frank@tuxrocks.com>
---
kernel/workqueue.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.19-fs1/kernel/workqueue.c
===================================================================
--- linux-2.6.19-fs1.orig/kernel/workqueue.c 2006-12-04
22:21:06.000000000 -0600
+++ linux-2.6.19-fs1/kernel/workqueue.c 2006-12-04 22:59:55.000000000 -0600
@@ -608,6 +608,7 @@
return ret;
}
+EXPORT_SYMBOL_GPL(current_is_keventd);
#ifdef CONFIG_HOTPLUG_CPU
/* Take the work from this (downed) CPU. */
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-05 20:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-05 0:07 2.6.19 git compile error - "current_is_keventd" [drivers/net/phy/libphy.ko] undefined art
2006-12-05 1:29 ` Horst H. von Brand
2006-12-05 3:37 ` Linus Torvalds
2006-12-05 18:31 ` Maciej W. Rozycki
2006-12-05 20:09 ` Jan Engelhardt
2006-12-05 5:08 ` [PATCH] " Frank Sorenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).