[ PATCH ] fix to documentation for kexec

[ PATCH ] fix to documentation for kexec

[Judith Lebzelter]

Hello,

I've noticed that the boot options are not correct for in 
the documentation for kdump. The "init" keyword is not 
necessary, and causes a kernel panic when booting with an 
initrd on Fedora 5.

Thanks;
Judith Lebzelter

---
Signed-off-by: Judith Lebzelter <judith@osdl.org>
---


Index: linux/Documentation/kdump/kdump.txt
===================================================================
--- linux.orig/Documentation/kdump/kdump.txt
+++ linux/Documentation/kdump/kdump.txt
@@ -207,7 +207,7 @@ the following command:
 
    kexec -p <dump-capture-kernel> \
    --initrd=<initrd-for-dump-capture-kernel> --args-linux \
-   --append="root=<root-dev> init 1 irqpoll"
+   --append="root=<root-dev> 1 irqpoll"
 
 
 Notes on loading the dump-capture kernel:
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode 
+  without networking. If you want networking, use "3".
 
 
 Kernel Panic

Re: [ PATCH ] fix to documentation for kexec

[Jan Engelhardt]

>@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
> * You must specify <root-dev> in the format corresponding to the root
>   device name in the output of mount command.
> 
>-* "init 1" boots the dump-capture kernel into single-user mode without
>-  networking. If you want networking, use "init 3."
>+* Boot parameter "1" boots the dump-capture kernel into single-user mode 
>+  without networking. If you want networking, use "3".

Yup. More precisely, any arguments that could not be parsed (because
the kernel does not know them) are handed down to the init program
as arguments and/or environment variables.


Jan
-- 
ft: http://freshmeat.net/p/chaostables/

Re: [ PATCH ] fix to documentation for kexec

[Robert P. J. Day]

On Thu, 1 Feb 2007, Judith Lebzelter wrote:

> Hello,
>
> I've noticed that the boot options are not correct for in
> the documentation for kdump. The "init" keyword is not
> necessary, and causes a kernel panic when booting with an
> initrd on Fedora 5.
>
> Thanks;
> Judith Lebzelter
>
> ---
> Signed-off-by: Judith Lebzelter <judith@osdl.org>
> ---
>
>
> Index: linux/Documentation/kdump/kdump.txt
> ===================================================================
> --- linux.orig/Documentation/kdump/kdump.txt
> +++ linux/Documentation/kdump/kdump.txt
> @@ -207,7 +207,7 @@ the following command:
>
>     kexec -p <dump-capture-kernel> \
>     --initrd=<initrd-for-dump-capture-kernel> --args-linux \
> -   --append="root=<root-dev> init 1 irqpoll"
> +   --append="root=<root-dev> 1 irqpoll"
>
>
>  Notes on loading the dump-capture kernel:
> @@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
>  * You must specify <root-dev> in the format corresponding to the root
>    device name in the output of mount command.
>
> -* "init 1" boots the dump-capture kernel into single-user mode without
> -  networking. If you want networking, use "init 3."
> +* Boot parameter "1" boots the dump-capture kernel into single-user mode
> +  without networking. If you want networking, use "3".

i'm not sure you want to totally remove those first two lines, they
appear to talk about getting to run level 1 *from a running system*.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================

Re: [ PATCH ] fix to documentation for kexec

[Robert P. J. Day]

On Thu, 1 Feb 2007, Jan Engelhardt wrote:

>
> >@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
> > * You must specify <root-dev> in the format corresponding to the root
> >   device name in the output of mount command.
> >
> >-* "init 1" boots the dump-capture kernel into single-user mode without
> >-  networking. If you want networking, use "init 3."
> >+* Boot parameter "1" boots the dump-capture kernel into single-user mode
> >+  without networking. If you want networking, use "3".
>
> Yup. More precisely, any arguments that could not be parsed (because
> the kernel does not know them) are handed down to the init program
> as arguments and/or environment variables.

whoops, ignore my last post, i misread the critical words.

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================

Re: [ PATCH ] fix to documentation for kexec

[Jan Engelhardt]

On Feb 1 2007 13:30, Robert P. J. Day wrote:
>> >@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
>> > * You must specify <root-dev> in the format corresponding to the root
>> >   device name in the output of mount command.
>> >
>> >-* "init 1" boots the dump-capture kernel into single-user mode without
>> >-  networking. If you want networking, use "init 3."
>> >+* Boot parameter "1" boots the dump-capture kernel into single-user mode
>> >+  without networking. If you want networking, use "3".
>>
>> Yup. More precisely, any arguments that could not be parsed (because
>> the kernel does not know them) are handed down to the init program
>> as arguments and/or environment variables.
>
>whoops, ignore my last post, i misread the critical words.

However, I am not sure how the kernel will handle this. Especially since:

  * if you boot with no initramfs, init= is handled by your script
    (otherwise: kernel)

  * does "init" qualify as a kernel param already? I don't think so,
    since the code indicates to be wanting "init=" at least.

Either way, the word "init" in the above doc is either (1) wrong
or (2) superfluous [unless something strange happens to interpret it later,
which I don't think]


Jan
-- 
ft: http://freshmeat.net/p/chaostables/

Re: [ PATCH ] fix to documentation for kexec

[Judith Lebzelter]

On Thu, Feb 01, 2007 at 07:33:58PM +0100, Jan Engelhardt wrote:
> 
> On Feb 1 2007 13:30, Robert P. J. Day wrote:
> >> >@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
> >> > * You must specify <root-dev> in the format corresponding to the root
> >> >   device name in the output of mount command.
> >> >
> >> >-* "init 1" boots the dump-capture kernel into single-user mode without
> >> >-  networking. If you want networking, use "init 3."
> >> >+* Boot parameter "1" boots the dump-capture kernel into single-user mode
> >> >+  without networking. If you want networking, use "3".
> >>
> >> Yup. More precisely, any arguments that could not be parsed (because
> >> the kernel does not know them) are handed down to the init program
> >> as arguments and/or environment variables.
> >
> >whoops, ignore my last post, i misread the critical words.
> 
> However, I am not sure how the kernel will handle this. Especially since:
> 
>   * if you boot with no initramfs, init= is handled by your script
>     (otherwise: kernel)
> 
>   * does "init" qualify as a kernel param already? I don't think so,
>     since the code indicates to be wanting "init=" at least.
> 
> Either way, the word "init" in the above doc is either (1) wrong
> or (2) superfluous [unless something strange happens to interpret it later,
> which I don't think]

Yes, it looks like "init=" is right, "init" is wrong.

I did notice that my patch is out of date for the latest kernel, 
however.  I can send an up to date one.

Judith
> 
> 
> Jan
> -- 
> ft: http://freshmeat.net/p/chaostables/

Re: [ PATCH ] fix to documentation for kexec

[Judith Lebzelter]

> 
> I did notice that my patch is out of date for the latest kernel, 
> however.  I can send an up to date one.
> 
This applies to 2.6.20-rc7

Signed-off-by: Judith Lebzeelter <judith@osdl.org>
---

Stop recommending incorrect/superfluous "init" boot parameter.

Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
===================================================================
--- linux-2.6.20-rc7.orig/Documentation/kdump/kdump.txt
+++ linux-2.6.20-rc7/Documentation/kdump/kdump.txt
@@ -311,10 +311,10 @@ Following are the arch specific command 
 loading dump-capture kernel.
 
 For i386, x86_64 and ia64:
-	"init 1 irqpoll maxcpus=1"
+	"1 irqpoll maxcpus=1"
 
 For ppc64:
-	"init 1 maxcpus=1 noirqdistrib"
+	"1 maxcpus=1 noirqdistrib"
 
 
 Notes on loading the dump-capture kernel:
@@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user 
+  mode without networking. If you want networking, use "3".
 
 * We generally don' have to bring up a SMP kernel just to capture the
   dump. Hence generally it is useful either to build a UP dump-capture

Re: [Fastboot] [ PATCH ] fix to documentation for kexec

[Vivek Goyal]

On Thu, Feb 01, 2007 at 10:58:08AM -0800, Judith Lebzelter wrote:
> > 
> > I did notice that my patch is out of date for the latest kernel, 
> > however.  I can send an up to date one.
> > 
> This applies to 2.6.20-rc7
> 
> Signed-off-by: Judith Lebzeelter <judith@osdl.org>
> ---
> 
> Stop recommending incorrect/superfluous "init" boot parameter.
> 

This looks good. The intention here is just to boot into run level 1, so
that minimum scripts run in user space and probability of capturing the
dump increases.

Fedora doc does say that appending "1" on command line will boot it
into runlevel 1. I hope same is true for other distributions too.

Thanks
Vivek

> Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
> ===================================================================
> --- linux-2.6.20-rc7.orig/Documentation/kdump/kdump.txt
> +++ linux-2.6.20-rc7/Documentation/kdump/kdump.txt
> @@ -311,10 +311,10 @@ Following are the arch specific command 
>  loading dump-capture kernel.
>  
>  For i386, x86_64 and ia64:
> -	"init 1 irqpoll maxcpus=1"
> +	"1 irqpoll maxcpus=1"
>  
>  For ppc64:
> -	"init 1 maxcpus=1 noirqdistrib"
> +	"1 maxcpus=1 noirqdistrib"
>  
>  
>  Notes on loading the dump-capture kernel:
> @@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
>  * You must specify <root-dev> in the format corresponding to the root
>    device name in the output of mount command.
>  
> -* "init 1" boots the dump-capture kernel into single-user mode without
> -  networking. If you want networking, use "init 3."
> +* Boot parameter "1" boots the dump-capture kernel into single-user 
> +  mode without networking. If you want networking, use "3".
>  
>  * We generally don' have to bring up a SMP kernel just to capture the
>    dump. Hence generally it is useful either to build a UP dump-capture
> _______________________________________________
> fastboot mailing list
> fastboot@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/fastboot

Re: [Fastboot] [ PATCH ] fix to documentation for kexec

[Horms]

On Thu, Feb 01, 2007 at 01:25:04PM -0500, Robert P. J. Day wrote:
> On Thu, 1 Feb 2007, Judith Lebzelter wrote:
> 
> > Hello,
> >
> > I've noticed that the boot options are not correct for in
> > the documentation for kdump. The "init" keyword is not
> > necessary, and causes a kernel panic when booting with an
> > initrd on Fedora 5.
> >
> > Thanks;
> > Judith Lebzelter
> >
> > ---
> > Signed-off-by: Judith Lebzelter <judith@osdl.org>
> > ---
> >
> >
> > Index: linux/Documentation/kdump/kdump.txt
> > ===================================================================
> > --- linux.orig/Documentation/kdump/kdump.txt
> > +++ linux/Documentation/kdump/kdump.txt
> > @@ -207,7 +207,7 @@ the following command:
> >
> >     kexec -p <dump-capture-kernel> \
> >     --initrd=<initrd-for-dump-capture-kernel> --args-linux \
> > -   --append="root=<root-dev> init 1 irqpoll"
> > +   --append="root=<root-dev> 1 irqpoll"
> >
> >
> >  Notes on loading the dump-capture kernel:
> > @@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
> >  * You must specify <root-dev> in the format corresponding to the root
> >    device name in the output of mount command.
> >
> > -* "init 1" boots the dump-capture kernel into single-user mode without
> > -  networking. If you want networking, use "init 3."
> > +* Boot parameter "1" boots the dump-capture kernel into single-user mode
> > +  without networking. If you want networking, use "3".
> 
> i'm not sure you want to totally remove those first two lines, they
> appear to talk about getting to run level 1 *from a running system*.

I think that it is refering to a kernel command line parameter,
not a shell command executed on a running system, so I think the patch
is correct in that respect.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

[PATCH] kexec: fix references to init in documentation for kexe

[Horms]

On Fri, Feb 02, 2007 at 01:32:40PM +0530, Vivek Goyal wrote:
> On Thu, Feb 01, 2007 at 10:58:08AM -0800, Judith Lebzelter wrote:
> > > 
> > > I did notice that my patch is out of date for the latest kernel, 
> > > however.  I can send an up to date one.
> > > 
> > This applies to 2.6.20-rc7
> > 
> > Signed-off-by: Judith Lebzeelter <judith@osdl.org>
> > ---
> > 
> > Stop recommending incorrect/superfluous "init" boot parameter.
> > 
> 
> This looks good. The intention here is just to boot into run level 1, so
> that minimum scripts run in user space and probability of capturing the
> dump increases.
> 
> Fedora doc does say that appending "1" on command line will boot it
> into runlevel 1. I hope same is true for other distributions too.
> 
> Thanks
> Vivek

This seems fine to me. Lets see if we can get it included.

-- 
Simon Horman (Horms)
  horms@verge.net.au
  http://verge.net.au/~horms/

kexec: fix references to init in documentation for kexec

I've noticed that the boot options are not correct for in
the documentation for kdump. The "init" keyword is not
necessary, and causes a kernel panic when booting with an
initrd on Fedora 5.

Signed-off-by: Judith Lebzeelter <judith@osdl.org>
Acked-by: Vivek Goyal <vgoyal@in.ibm.com>

Put original comment with the latest version of the patch

Signed-off-by: Simon Horman <horms@verge.net.au>

Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
===================================================================
--- linux-2.6.20-rc7.orig/Documentation/kdump/kdump.txt
+++ linux-2.6.20-rc7/Documentation/kdump/kdump.txt
@@ -311,10 +311,10 @@ Following are the arch specific command 
 loading dump-capture kernel.
 
 For i386, x86_64 and ia64:
-	"init 1 irqpoll maxcpus=1"
+	"1 irqpoll maxcpus=1"
 
 For ppc64:
-	"init 1 maxcpus=1 noirqdistrib"
+	"1 maxcpus=1 noirqdistrib"
 
 
 Notes on loading the dump-capture kernel:
@@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user 
+  mode without networking. If you want networking, use "3".
 
 * We generally don' have to bring up a SMP kernel just to capture the
   dump. Hence generally it is useful either to build a UP dump-capture

Re: [Fastboot] [ PATCH ] fix to documentation for kexec

[Lombard, David N]

On Wed, Feb 07, 2007 at 04:33:16PM +0900, Horms wrote:
> On Thu, Feb 01, 2007 at 01:25:04PM -0500, Robert P. J. Day wrote:
> > On Thu, 1 Feb 2007, Judith Lebzelter wrote:
> > >
> > > -* "init 1" boots the dump-capture kernel into single-user mode without
> > > -  networking. If you want networking, use "init 3."
> > > +* Boot parameter "1" boots the dump-capture kernel into single-user mode
> > > +  without networking. If you want networking, use "3".
> > 
> > i'm not sure you want to totally remove those first two lines, they
> > appear to talk about getting to run level 1 *from a running system*.
> 
> I think that it is refering to a kernel command line parameter,
> not a shell command executed on a running system, so I think the patch
> is correct in that respect.

Agree with removing the "init" word.  A single digit is assumed by the kernel
to be the run level.

Also, given the variability of those values, leave the current documentation
at levels 1 and 3.

BTW, the "init" keyword, *with* a value, specifies an alternate init process
binary, e.g,, the default is "init=/sbin/init"

-- 
David N. Lombard, Intel, Irvine, CA
I do not speak for Intel Corporation; all comments are strictly my own.