LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@linux01.gwdg.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c
Date: Wed, 7 Feb 2007 19:03:05 +0100 (MET)	[thread overview]
Message-ID: <Pine.LNX.4.61.0702071901150.20245@yvahk01.tjqt.qr> (raw)
In-Reply-To: <20070207072259.GA22083@lst.de>


On Feb 7 2007 08:22, Christoph Hellwig wrote:

>> That loop has (and had) up to O(n^n) operations.  Is there something which
>> prevents this from going insane?
>
>I don't think so.  Then again it's only called when you call quotaon on
>a mounted filesystem, and normally you don't have that many inodes
>instanciated at that time.

With filesystems that can turn on their quota after mount time (about 
every fs except xfs), I can surely have a ton of files open, and hence, 
if I understand correctly, have lots of inodes instantiated.


Jan
-- 

  reply	other threads:[~2007-02-07 18:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 13:23 Christoph Hellwig
2007-02-06 13:46 ` Jan Kara
2007-02-06 23:50 ` Andrew Morton
2007-02-07  7:22   ` Christoph Hellwig
2007-02-07 18:03     ` Jan Engelhardt [this message]
2007-02-07 19:06       ` Christoph Hellwig
2007-02-08 12:22         ` Jan Engelhardt
2007-02-07  8:35   ` Jan Kara
2007-02-08  9:01 ` Bill Huey
2007-02-09  7:14   ` Bill Huey
2007-02-09  7:23     ` Bill Huey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0702071901150.20245@yvahk01.tjqt.qr \
    --to=jengelh@linux01.gwdg.de \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).