LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@linux01.gwdg.de>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 03/18] Dont leak NT bit into next task
Date: Wed, 21 Feb 2007 18:14:08 +0100 (MET) [thread overview]
Message-ID: <Pine.LNX.4.61.0702211812480.12039@yvahk01.tjqt.qr> (raw)
In-Reply-To: <erh57g$oeb$1@sea.gmane.org>
On Feb 21 2007 11:00, Giuseppe Bilotta wrote:
>On Wednesday 21 February 2007 02:49, Greg KH wrote:
>
>> /* frame pointer must be last for get_wchan */
>> -#define SAVE_CONTEXT "pushq %%rbp ; movq %%rsi,%%rbp\n\t"
>> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t"
>> +#define SAVE_CONTEXT "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
>> +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"
>
>No idea if this is a problem or not, but you forgot a \n after popf.
It is on the edge. RESTORE_CONTEXT will not be passed any
arguments, so it is the only thing in a single line, and hence
the implicit \n of the source file applies after \t.
But yes, it may be dangerous. Better is an explicit \n or semicolon
after popf.
Jan
--
next prev parent reply other threads:[~2007-02-21 17:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070221014413.282048309@mini.kroah.org>
2007-02-21 1:49 ` [patch 00/18] 2.6.18-stable review Greg KH
2007-02-21 1:49 ` [patch 01/18] bcm43xx: Fix for oops on resume Greg KH
2007-02-23 5:25 ` Pavel Machek
2007-02-25 2:30 ` Larry Finger
2007-02-25 8:53 ` Andrew Morton
2007-02-21 1:49 ` [patch 02/18] bcm43xx: Fix for oops on ampdu status Greg KH
2007-02-21 1:49 ` [patch 03/18] Dont leak NT bit into next task Greg KH
2007-02-21 10:00 ` Giuseppe Bilotta
2007-02-21 17:14 ` Jan Engelhardt [this message]
2007-02-21 17:20 ` Chuck Ebbert
2007-02-22 15:29 ` Adrian Bunk
2007-02-22 16:56 ` Andi Kleen
2007-02-21 1:50 ` [patch 04/18] SCSI: add missing cdb clearing in scsi_execute() Greg KH
2007-02-21 1:50 ` [patch 05/18] IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G Greg KH
2007-02-21 1:50 ` [patch 06/18] i2c: fix broken ds1337 initialization Greg KH
2007-02-21 1:50 ` [patch 07/18] grow_buffers() infinite loop fix (CVE-2006-5757, CVE-2006-6060) Greg KH
2007-02-21 1:50 ` [patch 08/18] hfs_fill_super returns success even if no root inode (CVE-2006-6056) Greg KH
2007-02-21 1:50 ` [patch 09/18] IB/mad: Fix race between cancel and receive completion Greg KH
2007-02-21 1:50 ` [patch 10/18] dvb-core: fix bug in CRC-32 checking on 64-bit systems Greg KH
2007-02-21 1:50 ` [patch 11/18] v4l: cx2341x audio_properties is an u16, not u8 Greg KH
2007-02-21 1:50 ` [patch 12/18] v4l: cx88: Fix leadtek_eeprom tagging Greg KH
2007-02-21 1:51 ` [patch 13/18] V4L: cx88: Fix lockup on suspend Greg KH
2007-02-22 1:14 ` Michael Krufky
2007-02-23 23:50 ` Greg KH
2007-02-21 1:51 ` [patch 14/18] V4L: Fix quickcam communicator driver for big endian architectures Greg KH
2007-02-21 1:51 ` [patch 15/18] V4L: fix ks0127 status flags Greg KH
2007-02-21 1:51 ` [patch 16/18] V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37 Greg KH
2007-02-21 1:51 ` [patch 17/18] V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup Greg KH
2007-02-21 1:51 ` [patch 18/18] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Greg KH
2007-02-21 11:55 ` [patch 00/18] 2.6.18-stable review S.Çağlar Onur
2007-02-21 17:34 ` [stable] " Greg KH
2007-02-21 18:30 ` S.Çağlar Onur
2007-02-21 18:45 ` Ismail Dönmez
2007-02-22 5:42 ` Willy Tarreau
2007-02-26 0:00 ` Adrian Bunk
2007-02-26 0:18 ` Adrian Bunk
2007-03-05 13:44 ` S.Çağlar Onur
2007-03-05 19:26 ` Greg KH
2007-03-05 20:13 ` S.Çağlar Onur
2007-02-23 20:21 ` Hugh Dickins
2007-02-23 20:34 ` [stable] " Chris Wright
2007-02-23 21:13 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0702211812480.12039@yvahk01.tjqt.qr \
--to=jengelh@linux01.gwdg.de \
--cc=giuseppe.bilotta@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [patch 03/18] Dont leak NT bit into next task' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).