LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: 2.6.21-rc regression in mptbase
       [not found] <460475EF.1040109@vc.cvut.cz>
@ 2007-03-24  1:02 ` Petr Vandrovec
  2007-04-01 21:55   ` Jan Engelhardt
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Vandrovec @ 2007-03-24  1:02 UTC (permalink / raw)
  To: bunk; +Cc: linux-kernel, jengelh

> On Fri, Mar 23, 2007 at 11:39:12PM +0100, Jan Engelhardt wrote:
> > Hello world,
> > 
> > 
> > in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
> > broken with respect to not detecting any harddisk (VMware provides that 
> > virtual LSI MPT controller), which means no working system.
> > No problems in 2.6.20.2.
> >...
> 
> Could be a bug in the driver or a bug in the emulation exposed by a 
> change in the driver.
> 
> Can you bisect which change to the driver broke it?

Hello,
   it is bug in the emulation.  It should be fixed in Workstation 6.0 RC1.  If you
want to use VMware's LSILogic emulation with older products, you need fix below until
new releases come out (or unless I'll put out binary patch to fix binaries to
return 16 instead of previous value).
							Petr

If port reports that no devices are connected to it, assume that 16 devices
are there.  Hopefully nobody will ever build device with port but no devices,
and even for them it should be safe as before code always probed 16 devices
regardless of MaxDevices reported by port facts.

Signed-off-by:  Petr Vandrovec <petr@vandrovec.name>

--- linux/drivers/message/fusion/mptbase.c.orig	2007-03-20 13:47:28.000000000 -0700
+++ linux/drivers/message/fusion/mptbase.c	2007-03-23 17:45:51.000000000 -0700
@@ -2564,6 +2564,16 @@
 	pfacts->IOCStatus = le16_to_cpu(pfacts->IOCStatus);
 	pfacts->IOCLogInfo = le32_to_cpu(pfacts->IOCLogInfo);
 	pfacts->MaxDevices = le16_to_cpu(pfacts->MaxDevices);
+	/*
+	 * VMware emulation is broken, its PortFact's MaxDevices reports value
+	 * programmed by IOC Init, so if you program IOC Init to 256 (which is 0,
+	 * as that field is only 8 bit), it reports back 0 in port facts, instead
+	 * of 256...  And unfortunately using 256 triggers another bug in the
+	 * code (parallel SCSI can have only 16 devices).
+	 */
+	if (pfacts->MaxDevices == 0) {
+	   pfacts->MaxDevices = 16;
+	}
 	pfacts->PortSCSIID = le16_to_cpu(pfacts->PortSCSIID);
 	pfacts->ProtocolFlags = le16_to_cpu(pfacts->ProtocolFlags);
 	pfacts->MaxPostedCmdBuffers = le16_to_cpu(pfacts->MaxPostedCmdBuffers);

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.21-rc regression in mptbase
  2007-03-24  1:02 ` 2.6.21-rc regression in mptbase Petr Vandrovec
@ 2007-04-01 21:55   ` Jan Engelhardt
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2007-04-01 21:55 UTC (permalink / raw)
  To: Petr Vandrovec; +Cc: bunk, linux-kernel


On Mar 24 2007 02:02, Petr Vandrovec wrote:
>> > in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
>> > broken with respect to not detecting any harddisk (VMware provides that 
>> > virtual LSI MPT controller), which means no working system.
>> > No problems in 2.6.20.2.
>> 
>> Could be a bug in the driver or a bug in the emulation exposed by a 
>> change in the driver.
>> 
>Hello,
>   it is bug in the emulation.  It should be fixed in Workstation 6.0 RC1.  If you
>want to use VMware's LSILogic emulation with older products, you need fix below until
>new releases come out (or unless I'll put out binary patch to fix binaries to
>return 16 instead of previous value).

Yes (workaround works) and rc1 works. Thanks.


Jan
-- 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.21-rc regression in mptbase
  2007-03-23 22:39 Jan Engelhardt
  2007-03-23 23:06 ` Chuck Ebbert
@ 2007-03-24  0:30 ` Adrian Bunk
  1 sibling, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2007-03-24  0:30 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Linux Kernel Mailing List

On Fri, Mar 23, 2007 at 11:39:12PM +0100, Jan Engelhardt wrote:
> Hello world,
> 
> 
> in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
> broken with respect to not detecting any harddisk (VMware provides that 
> virtual LSI MPT controller), which means no working system.
> No problems in 2.6.20.2.
>...

Could be a bug in the driver or a bug in the emulation exposed by a 
change in the driver.

Can you bisect which change to the driver broke it?

> Jan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.21-rc regression in mptbase
  2007-03-23 23:06 ` Chuck Ebbert
@ 2007-03-24  0:14   ` Jan Engelhardt
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2007-03-24  0:14 UTC (permalink / raw)
  To: Chuck Ebbert; +Cc: Linux Kernel Mailing List, Adrian Bunk


On Mar 23 2007 19:06, Chuck Ebbert wrote:
>Jan Engelhardt wrote:
>> Hello world,
>> 
>> 
>> in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
>> broken with respect to not detecting any harddisk (VMware provides that 
>> virtual LSI MPT controller), which means no working system.
>> No problems in 2.6.20.2.
>> 
>> I will be trying 2.6.21-rc1 shortly.

Note: The harddisk is detected [or not] when mptspi.ko is loaded, but the
message that something has been detected is printed by mptbase, so I do not
exactly know which one is at fault.

>Also try 2.6.20.4. There are reports of this problem there as well.

Ok, will do that.

2.6.21-rc1 = broken
2.6.20.4   = works


Jan
-- 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.21-rc regression in mptbase
  2007-03-23 22:39 Jan Engelhardt
@ 2007-03-23 23:06 ` Chuck Ebbert
  2007-03-24  0:14   ` Jan Engelhardt
  2007-03-24  0:30 ` Adrian Bunk
  1 sibling, 1 reply; 6+ messages in thread
From: Chuck Ebbert @ 2007-03-23 23:06 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Linux Kernel Mailing List, Adrian Bunk

Jan Engelhardt wrote:
> Hello world,
> 
> 
> in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
> broken with respect to not detecting any harddisk (VMware provides that 
> virtual LSI MPT controller), which means no working system.
> No problems in 2.6.20.2.
> 
> I will be trying 2.6.21-rc1 shortly.
> 

Also try 2.6.20.4. There are reports of this problem there as well.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* 2.6.21-rc regression in mptbase
@ 2007-03-23 22:39 Jan Engelhardt
  2007-03-23 23:06 ` Chuck Ebbert
  2007-03-24  0:30 ` Adrian Bunk
  0 siblings, 2 replies; 6+ messages in thread
From: Jan Engelhardt @ 2007-03-23 22:39 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Adrian Bunk

Hello world,


in at least 2.6.21-rc4, one or more of the mptscsi scsi modules is 
broken with respect to not detecting any harddisk (VMware provides that 
virtual LSI MPT controller), which means no working system.
No problems in 2.6.20.2.

I will be trying 2.6.21-rc1 shortly.

2.6.20.2:
<6>PIIX4: IDE controller at PCI slot 0000:00:07.1
<6>PIIX4: chipset revision 1
<6>PIIX4: not 100% native mode: will probe irqs later
<6>    ide1: BM-DMA at 0x1058-0x105f, BIOS settings: hdc:DMA, hdd:pio
<7>Probing IDE interface ide1...
<4>hdc: VMware Virtual IDE CDROM Drive, ATAPI CD/DVD-ROM drive
<4>ide1 at 0x170-0x177,0x376 on irq 15
<6>Fusion MPT base driver 3.04.03
<6>Copyright (c) 1999-2007 LSI Logic Corporation
<6>Fusion MPT SPI Host driver 3.04.03
<6>ACPI: PCI Interrupt 0000:00:10.0[A] -> GSI 17 (level, low) -> IRQ 17
<6>mptbase: Initiating ioc0 bringup
<6>ioc0: 53C1030: Capabilities={Initiator}
<6>scsi0 : ioc0: LSI53C1030, FwRev=01032920h, Ports=1, MaxQ=128, IRQ=17
<5>scsi 0:0:0:0: Direct-Access     VMware,  VMware Virtual S 1.0  PQ: 0 ANSI: 2
<6> target0:0:0: Beginning Domain Validation
<6> target0:0:0: Domain Validation skipping write tests
<6> target0:0:0: Ending Domain Validation
<6> target0:0:0: FAST-40 WIDE SCSI 80.0 MB/s ST (25 ns, offset 127)
<5>SCSI device sda: 16777216 512-byte hdwr sectors (8590 MB)
<5>sda: Write Protect is off
<7>sda: Mode Sense: 5d 00 00 00
<5>sda: cache data unavailable
<3>sda: assuming drive cache: write through
<5>SCSI device sda: 16777216 512-byte hdwr sectors (8590 MB)
<5>sda: Write Protect is off
<7>sda: Mode Sense: 5d 00 00 00
<5>sda: cache data unavailable
<3>sda: assuming drive cache: write through
<6> sda: sda1 sda2
<5>sd 0:0:0:0: Attached scsi disk sda
<5>sd 0:0:0:0: Attached scsi generic sg0 type 0
<7>libata version 2.00 loaded.
<6>BIOS EDD facility v0.16 2004-Jun-25, 1 devices found
<6>SGI XFS with ACLs, security attributes, realtime, large block numbers, no debug enabled
<6>SGI XFS Quota Management subsystem
<5>XFS mounting filesystem sda2

2.6.21:
Loading piix
PIIX4: IDE controller at PCI slot 0000:00:07.1
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later
    ide1: BM-DMA at 0x1058-0x105f, BIOS settings: hdc:DMA, hdd:pio
hdc: VMware Virtual IDE CDROM Drive, ATAPI CD/DVD-ROM drive
ide1 at 0x170-0x177,0x376 on irq 15
Loading scsi_transport_spi
Loading mptbase
Fusion MPT base driver 3.04.04
Copyright (c) 1999-2007 LSI Logic Corporation
Loading mptscsih
Loading mptspi
Fusion MPT SPI Host driver 3.04.04
ACPI: PCI Interrupt 0000:00:10.0[A] -> GSI 17 (level, low) -> IRQ 17
mptbase: Initiating ioc0 bringup
ioc0: 53C1030: Capabilities={Initiator}
scsi0 : ioc0: LSI53C1030, FwRev=01032920h, Ports=1, MaxQ=128, IRQ=17
Loading libata
Loading ata_piix
Loading fan
Loading edd
BIOS EDD facility v0.16 2004-Jun-25, 1 devices found
Loading xfs
SGI XFS with ACLs, security attributes, realtime, large block numbers, no debug enabled
SGI XFS Quota Management subsystem
Waiting for device /dev/sda2 to appear: ...............




Jan
-- 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-04-01 21:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <460475EF.1040109@vc.cvut.cz>
2007-03-24  1:02 ` 2.6.21-rc regression in mptbase Petr Vandrovec
2007-04-01 21:55   ` Jan Engelhardt
2007-03-23 22:39 Jan Engelhardt
2007-03-23 23:06 ` Chuck Ebbert
2007-03-24  0:14   ` Jan Engelhardt
2007-03-24  0:30 ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).